Remove explicit enum values in EPosition.

Remove explicit enum values in EPosition.

Currently, the enum values of EPosition are specified explicitly (namely
EPosition::FixedPosition is set to 6 instead of the default of 4). This
was used for bit masking in LayoutObject, but no longer. This patch
removes the explicit enum values since we no longer depend on them.
LayoutObject's dependence on explicit enum values was removed in:
https://codereview.chromium.org/2664713002.

Note that TextAutoSizer::computeFingerprint is indirectly affected by
this patch because it assumes that EPosition uses 3 bits. However,
EPosition still uses 3 bits after this patch, so no change is required
here.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272
Review-Url: https://codereview.chromium.org/2667533002
Cr-Commit-Position: refs/heads/master@{#448192}
Committed: https://chromium.googlesource.com/chromium/src/+/d7bb23484bdfdc5f4141b7bf9de7815e28d1f1b5

[shend, 2017-01-31 00:50:02]

Description was changed from

==========
Remove explicit enum values in EPosition.

Currently, the enum values of EPosition are specified explicitly (namely
EPosition::FixedPosition is set to 6 instead of the default of 4). This
was used for bit masking in LayoutObject, but no longer. This patch
removes the explicit enum values since we no longer depend on them.

Note that TextAutoSizer::computeFingerprint is indirectly affected by
this patch because it assumes that EPosition uses 3 bits. However,
EPosition still uses 3 bits after this patch, so no change is required
here.

This is prework for converting EPosition to an enum class and generating
it.

BUG=684966
==========

to

==========
Remove explicit enum values in EPosition.

Currently, the enum values of EPosition are specified explicitly (namely
EPosition::FixedPosition is set to 6 instead of the default of 4). This
was used for bit masking in LayoutObject, but no longer. This patch
removes the explicit enum values since we no longer depend on them.

Note that TextAutoSizer::computeFingerprint is indirectly affected by
this patch because it assumes that EPosition uses 3 bits. However,
EPosition still uses 3 bits after this patch, so no change is required
here.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272
==========

[shend, 2017-01-31 00:52:37]

Description was changed from

==========
Remove explicit enum values in EPosition.

Currently, the enum values of EPosition are specified explicitly (namely
EPosition::FixedPosition is set to 6 instead of the default of 4). This
was used for bit masking in LayoutObject, but no longer. This patch
removes the explicit enum values since we no longer depend on them.

Note that TextAutoSizer::computeFingerprint is indirectly affected by
this patch because it assumes that EPosition uses 3 bits. However,
EPosition still uses 3 bits after this patch, so no change is required
here.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272
==========

to

==========
Remove explicit enum values in EPosition.

Currently, the enum values of EPosition are specified explicitly (namely
EPosition::FixedPosition is set to 6 instead of the default of 4). This
was used for bit masking in LayoutObject, but no longer. This patch
removes the explicit enum values since we no longer depend on them.
LayoutObject's dependence on explicit enum values was removed in:
https://codereview.chromium.org/2664713002.

Note that TextAutoSizer::computeFingerprint is indirectly affected by
this patch because it assumes that EPosition uses 3 bits. However,
EPosition still uses 3 bits after this patch, so no change is required
here.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272
==========

[shend, 2017-01-31 04:14:37]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-01-31 04:14:38]

Hey Alan PTAL :)

[shend, 2017-01-31 04:14:45]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 04:15:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 05:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 05:54:25]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-01-31 22:39:05]

sashab@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-01-31 22:39:06]

Yayy!! Nice work darren :) LGTM

Haha it still uses 3 bits that's funny. We confirmed that changing the fixed
position didn't introduce a perf regression correct?

[shend, 2017-01-31 22:54:22]

On 2017/01/31 at 22:39:06, sashab wrote:
> Yayy!! Nice work darren :) LGTM
> 
> Haha it still uses 3 bits that's funny. We confirmed that changing the fixed
position didn't introduce a perf regression correct?

I haven't tested it, but all I did was replace a bitmask with a switch
statement. I ran perf bots on a different patch where I did the same thing
(https://codereview.chromium.org/2652103002) and it was fine. But just to double
check I'll run some perf tests locally :)

[sashab, 2017-01-31 23:22:28]

Oh no that's OK - what I meant was did you run perfbots on the other patch,
which you did, that's great. No need to run it for this patch as well :)

Ehh, local perf tests can be unreliable, prefer the bots where you can :)

S

[shend, 2017-01-31 23:22:59]

On 2017/01/31 at 23:22:28, sashab wrote:
> Oh no that's OK - what I meant was did you run perfbots on the other patch,
which you did, that's great. No need to run it for this patch as well :)
> 
> Ehh, local perf tests can be unreliable, prefer the bots where you can :)
> 
> S

Alright will do.

[shend, 2017-02-01 21:40:55]

On 2017/01/31 at 23:22:59, shend wrote:
> On 2017/01/31 at 23:22:28, sashab wrote:
> > Oh no that's OK - what I meant was did you run perfbots on the other patch,
which you did, that's great. No need to run it for this patch as well :)
> > 
> > Ehh, local perf tests can be unreliable, prefer the bots where you can :)
> > 
> > S
> 
> Alright will do.

Perf test in https://codereview.chromium.org/2662423002 , there were two
failures but I can't access the logs for some reason. Could be flaky?

[shend, 2017-02-02 06:15:17]

On 2017/02/01 at 21:40:55, shend wrote:
> On 2017/01/31 at 23:22:59, shend wrote:
> > On 2017/01/31 at 23:22:28, sashab wrote:
> > > Oh no that's OK - what I meant was did you run perfbots on the other
patch, which you did, that's great. No need to run it for this patch as well :)
> > > 
> > > Ehh, local perf tests can be unreliable, prefer the bots where you can :)
> > > 
> > > S
> > 
> > Alright will do.
> 
> Perf test in https://codereview.chromium.org/2662423002 , there were two
failures but I can't access the logs for some reason. Could be flaky?

Ran blink_style.top_25 in https://codereview.chromium.org/2662423002 . The
numbers don't seem to have changed significantly, although I don't really know
how to interpret the results (is larger or smaller better)?

[sashab, 2017-02-03 05:07:08]

LGTM, discussed perf results offline and decided no regression introduced

[shend, 2017-02-05 22:25:01]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-02-05 22:25:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 00:03:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486333501434210, "parent_rev":
"2388829cd73f569cfcfb503f86025c5d051f7026", "commit_rev":
"d7bb23484bdfdc5f4141b7bf9de7815e28d1f1b5"}

[commit-bot: I haz the power, 2017-02-06 00:04:03]

Description was changed from

==========
Remove explicit enum values in EPosition.

Currently, the enum values of EPosition are specified explicitly (namely
EPosition::FixedPosition is set to 6 instead of the default of 4). This
was used for bit masking in LayoutObject, but no longer. This patch
removes the explicit enum values since we no longer depend on them.
LayoutObject's dependence on explicit enum values was removed in:
https://codereview.chromium.org/2664713002.

Note that TextAutoSizer::computeFingerprint is indirectly affected by
this patch because it assumes that EPosition uses 3 bits. However,
EPosition still uses 3 bits after this patch, so no change is required
here.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272
==========

to

==========
Remove explicit enum values in EPosition.

Currently, the enum values of EPosition are specified explicitly (namely
EPosition::FixedPosition is set to 6 instead of the default of 4). This
was used for bit masking in LayoutObject, but no longer. This patch
removes the explicit enum values since we no longer depend on them.
LayoutObject's dependence on explicit enum values was removed in:
https://codereview.chromium.org/2664713002.

Note that TextAutoSizer::computeFingerprint is indirectly affected by
this patch because it assumes that EPosition uses 3 bits. However,
EPosition still uses 3 bits after this patch, so no change is required
here.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272

Review-Url: https://codereview.chromium.org/2667533002
Cr-Commit-Position: refs/heads/master@{#448192}
Committed:
https://chromium.googlesource.com/chromium/src/+/d7bb23484bdfdc5f4141b7bf9de7...
==========

[commit-bot: I haz the power, 2017-02-06 00:04:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7bb23484bdfdc5f4141b7bf9de7...