Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2662423002: Perf test for changing bit masks into switch statements in LayoutObject (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 10 months ago
Reviewers:
sashab
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Perf test for changing bit masks into switch statements in LayoutObject Reverts https://codereview.chromium.org/2664713002 to test the perf impact. Not to be merged in. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sashab
Which tests did you run? The results look strange: https://00e9e64bac01e8fddf95ae2792fa6c4325e02931d8887291ef-apidata.googleusercontent.com/download/storage/v1/b/chromium-telemetry/o/html-results%2Fresults-2017-01-31_22-59-28?qk=AD5uMEtVfLCdQdyowjsdwENOJ9TsYvFXRk7tBWJtIMk9uICy3PNpZwf0goX21SW357O8nKBVkx-gNMt-HKqiPrGfXJCK1Sc9gZmWhw8C1cTAKngf29uvfT1nN-95vQwU1ByPzFAX5x0OWO3RUNJxQpT2IzxScg7vgNkUh05xMtsknFFf0UrbD0LPAaUOEae-mDyl0qfAfmFJyA7xhJokbgg6vvG8WtZVMRj7W-QHVtCNO-oPFUAXSdw7jeUE0OrzEEYYh5bFtt5quk0gpylic9G3cLlBEOiQA2UJOh1QqumsCt1VHPWmcxEHEDArr_D_uKmR5p6IHMiNLJ-KKbxze8kZCUW7E6h-eEgyO0IGtYALniK7SES79g5CGyylYTCDjCfEE-dyYOQj0SKQZY1CAni39IV44XekrbdcVOKuc_8bPXppfCUUVxQoC2WRfNfw-xeNnwgvgi5AJWNdr5H9_mKlQVlf0IPCCWZQeEwzzjr-sb4h7aupcCEyeNjEw7BAqHlQfB3QMBDfxyJO6WVq0qjR4JEfdFzJatb15Vu1170CYS9YpETG8KSrvRvFa-DPWRld_oDpfiP-9J2w5zmrhxjXYLQmGglVYgq7IeAyzDU2GmeloQBGVeneh-yl6xLMF2xbTOruXnftEq9Ve-CHP49TDPbdGgCi9oYKppD6FjLHd5dImHk6JZHaJKmV0JOI6CSQgX-V42R0QNqduO8tFe7nnFUBxjBqz_Ux4hHJBnMVdEIHcxNX7i2ZkIY2EuAZL9y02YGVQJObOg6M4RzDbaJuGh0ESAsMjffDDZeCuVDN2OGUPvAUqPg--73EVJ2trd1yomtGaDOv I think you probably want ...
3 years, 10 months ago (2017-02-01 22:07:12 UTC) #2
sashab
Yes, red bots are flaky. Perf bots will always pass, and link to their HTML ...
3 years, 10 months ago (2017-02-01 22:07:34 UTC) #3
shend
On 2017/02/01 at 22:07:34, sashab wrote: > Yes, red bots are flaky. Perf bots will ...
3 years, 10 months ago (2017-02-01 22:40:31 UTC) #4
shend
3 years, 10 months ago (2017-02-01 22:40:31 UTC) #5 
On 2017/02/01 at 22:07:34, sashab wrote:
> Yes, red bots are flaky. Perf bots will always pass, and link to their HTML
results which show the real result.

Oh I ran blink_perf.layout (since I changed LayoutObject). Is blink_style.top_25
the canonical one to run?

Powered by Google App Engine
This is Rietveld 408576698