Use switch statement instead of bit masking for EPosition.

Use switch statement instead of bit masking for EPosition.

Currently, LayoutObject converts EPosition objects into an internal
representation using bit masking. However, as part of generating
ComputedStyle, there will no longer be a guarantee on the EPosition
enumerator values, so the bit masking will not work. This patch converts
the bit masking to an explicit switch statements that converts EPosition
to the internal LayoutObject representation.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272
Review-Url: https://codereview.chromium.org/2664713002
Cr-Commit-Position: refs/heads/master@{#447186}
Committed: https://chromium.googlesource.com/chromium/src/+/1aa5a2b59d912d6781ec85942708efebe2e19314

[shend, 2017-01-30 05:21:19]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-01-30 05:21:19]

Hey Bugs, PTAL :)

[shend, 2017-01-30 06:48:33]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 06:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 09:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 09:31:34]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-01-30 19:47:09]

lgtm

[shend, 2017-01-30 21:35:11]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-01-30 21:35:11]

Hey Sasha, PTAL :)

[sashab, 2017-01-30 23:44:53]

LGTM, bug should be 665272 though :)

[shend, 2017-01-30 23:46:58]

Description was changed from

==========
Use switch statement instead of bit masking for EPosition.

Currently, LayoutObject converts EPosition objects into an internal
representation using bit masking. However, as part of generating
ComputedStyle, there will no longer be a guarantee on the EPosition
enumerator values, so the bit masking will not work. This patch converts
the bit masking to an explicit switch statements that converts EPosition
to the internal LayoutObject representation.

This is prework for converting EPosition to an enum class and generating
it.

BUG=684966
==========

to

==========
Use switch statement instead of bit masking for EPosition.

Currently, LayoutObject converts EPosition objects into an internal
representation using bit masking. However, as part of generating
ComputedStyle, there will no longer be a guarantee on the EPosition
enumerator values, so the bit masking will not work. This patch converts
the bit masking to an explicit switch statements that converts EPosition
to the internal LayoutObject representation.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272
==========

[shend, 2017-01-31 03:57:23]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-01-31 03:57:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 04:03:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485835043191580,
"parent_rev": "5b4a1953011fa32b01bc96c96e71bee6b6aca464", "commit_rev":
"1aa5a2b59d912d6781ec85942708efebe2e19314"}

[commit-bot: I haz the power, 2017-01-31 04:04:53]

Description was changed from

==========
Use switch statement instead of bit masking for EPosition.

Currently, LayoutObject converts EPosition objects into an internal
representation using bit masking. However, as part of generating
ComputedStyle, there will no longer be a guarantee on the EPosition
enumerator values, so the bit masking will not work. This patch converts
the bit masking to an explicit switch statements that converts EPosition
to the internal LayoutObject representation.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272
==========

to

==========
Use switch statement instead of bit masking for EPosition.

Currently, LayoutObject converts EPosition objects into an internal
representation using bit masking. However, as part of generating
ComputedStyle, there will no longer be a guarantee on the EPosition
enumerator values, so the bit masking will not work. This patch converts
the bit masking to an explicit switch statements that converts EPosition
to the internal LayoutObject representation.

This is prework for converting EPosition to an enum class and generating
it.

BUG=665272

Review-Url: https://codereview.chromium.org/2664713002
Cr-Commit-Position: refs/heads/master@{#447186}
Committed:
https://chromium.googlesource.com/chromium/src/+/1aa5a2b59d912d6781ec85942708...
==========

[commit-bot: I haz the power, 2017-01-31 04:04:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1aa5a2b59d912d6781ec85942708...