Try to rename LayoutDistanceType enum values for clarity and consistency.

Try to rename LayoutDistanceType enum values for clarity and consistency.

BUTTON_[H,V]EDGE_MARGIN_NEW -> DIALOG_BUTTON_MARGIN
Combined these two (which are the same in both pre-Harmony and Harmony) into
one.  Eliminated NEW (was unfortunate even in the original pre-Harmony name and
is especially misleading now).  Tried to choose a naming structure for
parallelism with PANEL_CONTENT_MARGIN (see below): the dialog-scope margin
around buttons.

CHECKBOX_INDENT -> SUBSECTION_HORIZONTAL_INDENT
Added HORIZONTAL to match other names that are specific to horizontal vs
vertical.  Changed to SUBSECTION based on
https://codereview.chromium.org/2654123004/ .

PANEL_[HORIZ,VERT]_MARGIN -> PANEL_CONTENT_MARGIN
Again, combined two always-the same constants into one.

UNRELATED_CONTROL_LARGE_VERTICAL_SPACING ->
UNRELATED_CONTROL_VERTICAL_SPACING_LARGE
Moved "large" to the end so this would sort alphabetically by the non-LARGE
version.

I also sorted the declarations/switch statements for these into alphabetical
order, and tried to improve some comments.

In a future cleanup, I'd like to change existing uses of the old layout
constants to these values (which wiill help with Harmonization in general) and
then remove the old constants, which will eliminate things like name mismatches
between the old and new names.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2666043002
Cr-Commit-Position: refs/heads/master@{#447425}
Committed: https://chromium.googlesource.com/chromium/src/+/ab0b37a4184cccbdd9ffaaaf5e95e56b415a0fbf

[Peter Kasting, 2017-01-31 07:40:44]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 07:40:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-01-31 07:41:04]

Description was changed from

==========
Try to rename LayoutDistanceType enum values for clarity and consistency.

BUTTON_[H,V]EDGE_MARGIN_NEW -> DIALOG_BUTTON_MARGIN
Combined these two (which are the same in both pre-Harmony and Harmony) into
one.  Eliminated NEW (was unfortunate even in the original pre-Harmony name and
is especially misleading now).  Tried to choose a naming structure for
parallelism with PANEL_CONTENT_MARGIN (see below): the dialog-scope margin
around buttons.

CHECKBOX_INDENT -> SUBSECTION_HORIZONTAL_INDENT
Added HORIZONTAL to match other names that are specific to horizontal vs
vertical.  Changed to SUBSECTION based on
https://codereview.chromium.org/2654123004/ .

PANEL_[HORIZ,VERT]_MARGIN -> PANEL_CONTENT_MARGIN
Again, combined two always-the same constants into one.

UNRELATED_CONTROL_LARGE_VERTICAL_SPACING ->
UNRELATED_CONTROL_VERTICAL_SPACING_LARGE
Moved "large" to the end so this would sort alphabetically by the non-LARGE
version.

I also sorted the declarations/switch statements for these into alphabetical
order.

In a future cleanup, I'd like to change existing uses of the old layout
constants to these values (which wiill help with Harmonization in general) and
then remove the old constants, which will eliminate things like name mismatches
between the old and new names.

BUG=none
TEST=none
==========

to

==========
Try to rename LayoutDistanceType enum values for clarity and consistency.

BUTTON_[H,V]EDGE_MARGIN_NEW -> DIALOG_BUTTON_MARGIN
Combined these two (which are the same in both pre-Harmony and Harmony) into
one.  Eliminated NEW (was unfortunate even in the original pre-Harmony name and
is especially misleading now).  Tried to choose a naming structure for
parallelism with PANEL_CONTENT_MARGIN (see below): the dialog-scope margin
around buttons.

CHECKBOX_INDENT -> SUBSECTION_HORIZONTAL_INDENT
Added HORIZONTAL to match other names that are specific to horizontal vs
vertical.  Changed to SUBSECTION based on
https://codereview.chromium.org/2654123004/ .

PANEL_[HORIZ,VERT]_MARGIN -> PANEL_CONTENT_MARGIN
Again, combined two always-the same constants into one.

UNRELATED_CONTROL_LARGE_VERTICAL_SPACING ->
UNRELATED_CONTROL_VERTICAL_SPACING_LARGE
Moved "large" to the end so this would sort alphabetically by the non-LARGE
version.

I also sorted the declarations/switch statements for these into alphabetical
order, and tried to improve some comments.

In a future cleanup, I'd like to change existing uses of the old layout
constants to these values (which wiill help with Harmonization in general) and
then remove the old constants, which will eliminate things like name mismatches
between the old and new names.

BUG=none
TEST=none
==========

[Peter Kasting, 2017-01-31 07:41:04]

pkasting@chromium.org changed reviewers:
+ ellyjones@chromium.org

[commit-bot: I haz the power, 2017-01-31 08:29:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 08:29:57]

Dry run: This issue passed the CQ dry run.

[Elly Fong-Jones, 2017-01-31 15:30:11]

lgtm

[Peter Kasting, 2017-01-31 21:42:53]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2017-01-31 21:44:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 22:01:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 22:01:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Kasting, 2017-02-01 01:46:26]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2017-02-01 01:47:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 02:41:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485913586585220,
"parent_rev": "ff3381d6a029803db825aa0a52a49510f6273e5c", "commit_rev":
"ab0b37a4184cccbdd9ffaaaf5e95e56b415a0fbf"}

[commit-bot: I haz the power, 2017-02-01 02:41:51]

Description was changed from

==========
Try to rename LayoutDistanceType enum values for clarity and consistency.

BUTTON_[H,V]EDGE_MARGIN_NEW -> DIALOG_BUTTON_MARGIN
Combined these two (which are the same in both pre-Harmony and Harmony) into
one.  Eliminated NEW (was unfortunate even in the original pre-Harmony name and
is especially misleading now).  Tried to choose a naming structure for
parallelism with PANEL_CONTENT_MARGIN (see below): the dialog-scope margin
around buttons.

CHECKBOX_INDENT -> SUBSECTION_HORIZONTAL_INDENT
Added HORIZONTAL to match other names that are specific to horizontal vs
vertical.  Changed to SUBSECTION based on
https://codereview.chromium.org/2654123004/ .

PANEL_[HORIZ,VERT]_MARGIN -> PANEL_CONTENT_MARGIN
Again, combined two always-the same constants into one.

UNRELATED_CONTROL_LARGE_VERTICAL_SPACING ->
UNRELATED_CONTROL_VERTICAL_SPACING_LARGE
Moved "large" to the end so this would sort alphabetically by the non-LARGE
version.

I also sorted the declarations/switch statements for these into alphabetical
order, and tried to improve some comments.

In a future cleanup, I'd like to change existing uses of the old layout
constants to these values (which wiill help with Harmonization in general) and
then remove the old constants, which will eliminate things like name mismatches
between the old and new names.

BUG=none
TEST=none
==========

to

==========
Try to rename LayoutDistanceType enum values for clarity and consistency.

BUTTON_[H,V]EDGE_MARGIN_NEW -> DIALOG_BUTTON_MARGIN
Combined these two (which are the same in both pre-Harmony and Harmony) into
one.  Eliminated NEW (was unfortunate even in the original pre-Harmony name and
is especially misleading now).  Tried to choose a naming structure for
parallelism with PANEL_CONTENT_MARGIN (see below): the dialog-scope margin
around buttons.

CHECKBOX_INDENT -> SUBSECTION_HORIZONTAL_INDENT
Added HORIZONTAL to match other names that are specific to horizontal vs
vertical.  Changed to SUBSECTION based on
https://codereview.chromium.org/2654123004/ .

PANEL_[HORIZ,VERT]_MARGIN -> PANEL_CONTENT_MARGIN
Again, combined two always-the same constants into one.

UNRELATED_CONTROL_LARGE_VERTICAL_SPACING ->
UNRELATED_CONTROL_VERTICAL_SPACING_LARGE
Moved "large" to the end so this would sort alphabetically by the non-LARGE
version.

I also sorted the declarations/switch statements for these into alphabetical
order, and tried to improve some comments.

In a future cleanup, I'd like to change existing uses of the old layout
constants to these values (which wiill help with Harmonization in general) and
then remove the old constants, which will eliminate things like name mismatches
between the old and new names.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2666043002
Cr-Commit-Position: refs/heads/master@{#447425}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab0b37a4184cccbdd9ffaaaf5e95...
==========

[commit-bot: I haz the power, 2017-02-01 02:41:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ab0b37a4184cccbdd9ffaaaf5e95...