Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: chrome/browser/ui/views/login_view.cc

Issue 2666043002: Try to rename LayoutDistanceType enum values for clarity and consistency. (Closed)
Patch Set: Fix comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/layout_utils.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/login_view.h" 5 #include "chrome/browser/ui/views/login_view.h"
6 6
7 #include "chrome/browser/ui/views/harmony/layout_delegate.h" 7 #include "chrome/browser/ui/views/harmony/layout_delegate.h"
8 #include "chrome/browser/ui/views/layout_utils.h" 8 #include "chrome/browser/ui/views/layout_utils.h"
9 #include "components/strings/grit/components_strings.h" 9 #include "components/strings/grit/components_strings.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 message_label_->SetAllowCharacterBreak(true); 75 message_label_->SetAllowCharacterBreak(true);
76 layout->AddPaddingRow(0, layout_delegate->GetLayoutDistance( 76 layout->AddPaddingRow(0, layout_delegate->GetLayoutDistance(
77 LayoutDelegate::LayoutDistanceType:: 77 LayoutDelegate::LayoutDistanceType::
78 RELATED_CONTROL_VERTICAL_SPACING)); 78 RELATED_CONTROL_VERTICAL_SPACING));
79 layout->StartRow(0, single_column_view_set_id); 79 layout->StartRow(0, single_column_view_set_id);
80 layout->AddView(message_label_); 80 layout->AddView(message_label_);
81 } 81 }
82 82
83 layout->AddPaddingRow(0, layout_delegate->GetLayoutDistance( 83 layout->AddPaddingRow(0, layout_delegate->GetLayoutDistance(
84 LayoutDelegate::LayoutDistanceType:: 84 LayoutDelegate::LayoutDistanceType::
85 UNRELATED_CONTROL_LARGE_VERTICAL_SPACING)); 85 UNRELATED_CONTROL_VERTICAL_SPACING_LARGE));
86 86
87 layout->StartRow(0, labels_column_set_id); 87 layout->StartRow(0, labels_column_set_id);
88 layout->AddView(username_label_); 88 layout->AddView(username_label_);
89 layout->AddView(username_field_); 89 layout->AddView(username_field_);
90 90
91 layout->AddPaddingRow(0, layout_delegate->GetLayoutDistance( 91 layout->AddPaddingRow(0, layout_delegate->GetLayoutDistance(
92 LayoutDelegate::LayoutDistanceType:: 92 LayoutDelegate::LayoutDistanceType::
93 RELATED_CONTROL_VERTICAL_SPACING)); 93 RELATED_CONTROL_VERTICAL_SPACING));
94 94
95 layout->StartRow(0, labels_column_set_id); 95 layout->StartRow(0, labels_column_set_id);
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 void LoginView::OnLoginModelDestroying() { 141 void LoginView::OnLoginModelDestroying() {
142 login_model_->RemoveObserver(this); 142 login_model_->RemoveObserver(this);
143 login_model_ = NULL; 143 login_model_ = NULL;
144 } 144 }
145 145
146 const char* LoginView::GetClassName() const { 146 const char* LoginView::GetClassName() const {
147 return "LoginView"; 147 return "LoginView";
148 } 148 }
149 149
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/layout_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698