Rename various LayoutDelegate types/functions for brevity and consistency.

Rename various LayoutDelegate types/functions for brevity and consistency.

* "Type" was removed from the enum class names; many of the enums in the
  codebase are types of things, but we don't normally append "type".  Removing
  this left the code reading about as clearly as before to me, but was more
  consistent with elsewhere, and briefer.

* LayoutDistance -> Metric.  "Layout" is redundant with LayoutDelegate, which is
  used to qualify accesses to the enum anyway, and "distance" seems less clear
  to me than "metric" (plus is longer), especially if in the future we add
  values that are less obviously distances, e.g. font sizes or something.

The primary goal of these changes was to reduce the verbosity at call sites.  I
hope to use these much more broadly across views, but the current syntax felt
very long-winded.  It seems like maybe more could be done, but this is a start.

Of course, due to the vagaries of git cl format, this ended up being wrapped
over more lines than before, but it's less verbose doing so.  :P

Also changed one const to constexpr.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2663013003
Cr-Commit-Position: refs/heads/master@{#447429}
Committed: https://chromium.googlesource.com/chromium/src/+/a023c75cbfdf289ca3104d272c16447dead2c1a5

[Peter Kasting, 2017-01-31 10:26:33]

Description was changed from

==========
Rename various LayoutDelegate types/functions for brevity and consistency.

* "Type" was removed from the enum class names; many of the enums in the
  codebase are types of things, but we don't normally append "type".  Removing
  this left the code reading about as clearly as before to me, but was more
  consistent with elsewhere, and briefer.

* LayoutDistance -> Metric.  "Layout" is redundant with LayoutDelegate, which is
  used to qualify accesses to the enum anyway, and "distance" seems less clear
  to me than "metric" (plus is longer), especially if in the future we add
  values that are less obviously distances, e.g. font sizes or something.

The primary goal of these changes was to reduce the verbosity at call sites.  I
hope to use these much more broadly across views, but the current syntax felt
very long-winded.  It seems like maybe more could be done, but this is a start.

BUG=none
TEST=none
==========

to

==========
Rename various LayoutDelegate types/functions for brevity and consistency.

* "Type" was removed from the enum class names; many of the enums in the
  codebase are types of things, but we don't normally append "type".  Removing
  this left the code reading about as clearly as before to me, but was more
  consistent with elsewhere, and briefer.

* LayoutDistance -> Metric.  "Layout" is redundant with LayoutDelegate, which is
  used to qualify accesses to the enum anyway, and "distance" seems less clear
  to me than "metric" (plus is longer), especially if in the future we add
  values that are less obviously distances, e.g. font sizes or something.

The primary goal of these changes was to reduce the verbosity at call sites.  I
hope to use these much more broadly across views, but the current syntax felt
very long-winded.  It seems like maybe more could be done, but this is a start.

Of course, due to the vagaries of git cl format, this ended up being wrapped
over more lines than before, but it's less verbose doing so.  :P

Also changed one const to constexpr.

BUG=none
TEST=none
==========

[Peter Kasting, 2017-01-31 10:26:33]

pkasting@chromium.org changed reviewers:
+ ellyjones@chromium.org

[Peter Kasting, 2017-01-31 10:28:19]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 10:28:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 11:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 11:09:18]

Dry run: This issue passed the CQ dry run.

[Elly Fong-Jones, 2017-01-31 15:42:14]

lgtm but I think this might need git cl format

https://codereview.chromium.org/2663013003/diff/1/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc (right):

https://codereview.chromium.org/2663013003/diff/1/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc:355: 0,
is this what 'git cl format' does?

[Peter Kasting, 2017-01-31 21:41:55]

https://codereview.chromium.org/2663013003/diff/1/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc (right):

https://codereview.chromium.org/2663013003/diff/1/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc:355: 0,
On 2017/01/31 15:42:14, Elly Fong-Jones wrote:
> is this what 'git cl format' does?

Yes.  I was surprised.

[Peter Kasting, 2017-02-01 02:42:18]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2017-02-01 02:42:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 02:47:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485916938750940, "parent_rev":
"c3b7f8591aa0452f7e3abad630567dc316b62f06", "commit_rev":
"a023c75cbfdf289ca3104d272c16447dead2c1a5"}

[commit-bot: I haz the power, 2017-02-01 02:48:13]

Description was changed from

==========
Rename various LayoutDelegate types/functions for brevity and consistency.

* "Type" was removed from the enum class names; many of the enums in the
  codebase are types of things, but we don't normally append "type".  Removing
  this left the code reading about as clearly as before to me, but was more
  consistent with elsewhere, and briefer.

* LayoutDistance -> Metric.  "Layout" is redundant with LayoutDelegate, which is
  used to qualify accesses to the enum anyway, and "distance" seems less clear
  to me than "metric" (plus is longer), especially if in the future we add
  values that are less obviously distances, e.g. font sizes or something.

The primary goal of these changes was to reduce the verbosity at call sites.  I
hope to use these much more broadly across views, but the current syntax felt
very long-winded.  It seems like maybe more could be done, but this is a start.

Of course, due to the vagaries of git cl format, this ended up being wrapped
over more lines than before, but it's less verbose doing so.  :P

Also changed one const to constexpr.

BUG=none
TEST=none
==========

to

==========
Rename various LayoutDelegate types/functions for brevity and consistency.

* "Type" was removed from the enum class names; many of the enums in the
  codebase are types of things, but we don't normally append "type".  Removing
  this left the code reading about as clearly as before to me, but was more
  consistent with elsewhere, and briefer.

* LayoutDistance -> Metric.  "Layout" is redundant with LayoutDelegate, which is
  used to qualify accesses to the enum anyway, and "distance" seems less clear
  to me than "metric" (plus is longer), especially if in the future we add
  values that are less obviously distances, e.g. font sizes or something.

The primary goal of these changes was to reduce the verbosity at call sites.  I
hope to use these much more broadly across views, but the current syntax felt
very long-winded.  It seems like maybe more could be done, but this is a start.

Of course, due to the vagaries of git cl format, this ended up being wrapped
over more lines than before, but it's less verbose doing so.  :P

Also changed one const to constexpr.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2663013003
Cr-Commit-Position: refs/heads/master@{#447429}
Committed:
https://chromium.googlesource.com/chromium/src/+/a023c75cbfdf289ca3104d272c16...
==========

[commit-bot: I haz the power, 2017-02-01 02:48:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a023c75cbfdf289ca3104d272c16...