Issue 266473009: Fix & clarify some comments in compositing. Rename clippedByAncestor to more accurately

Issue 266473009: Fix & clarify some comments in compositing. Rename clippedByAncestor to more accurately (Closed)

Created:
6 years, 7 months ago by chrishtr

Modified:
6 years, 7 months ago

Reviewers:
Ian Vollick

CC:
blink-reviews, blink-reviews-rendering, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix & clarify some comments in compositing. Rename clippedByAncestor to more accurately describe what it actually does. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173017

Patch Set 1 #

Patch Set 2 : Make conditionals clearer in shouldClipCompositedBounds #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/compositing/CompositedLayerMapping.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/compositing/CompositedLayerMapping.cpp	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

chrishtr

Also rewrote some code in CompositedLayerMapping::shouldClipCompositedBounds to make it clearer what is going on, but ...

6 years, 7 months ago (2014-04-30 18:20:14 UTC) #2

Ian Vollick

On 2014/04/30 18:20:14, chrishtr wrote: > Also rewrote some code in CompositedLayerMapping::shouldClipCompositedBounds to > make ...

6 years, 7 months ago (2014-04-30 18:27:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/266473009/20001

6 years, 7 months ago (2014-04-30 18:41:48 UTC) #5

Message was sent while issue was closed.

Change committed as 173017

Expand Messages | Collapse Messages