Source/core/rendering/compositing/RenderLayerCompositor.h - Issue 266473009: Fix & clarify some comments in compositing. Rename clippedByAncestor to more accurately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.h

Issue 266473009: Fix & clarify some comments in compositing. Rename clippedByAncestor to more accurately (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make conditionals clearer in shouldClipCompositedBounds Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/compositing/CompositedLayerMapping.cpp ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/RenderLayerCompositor.h

diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.h b/Source/core/rendering/compositing/RenderLayerCompositor.h

index 0d3d89899a019438b76b398ffdf32855f63399a1..b6c1ab69d4718bbd67a84871db08c17009f9c39e 100644

--- a/Source/core/rendering/compositing/RenderLayerCompositor.h

+++ b/Source/core/rendering/compositing/RenderLayerCompositor.h

@@ -114,8 +114,8 @@ public:

// (At the moment, it also has some legacy compatibility hacks.)

void updateLayerCompositingState(RenderLayer*, UpdateLayerCompositingStateOptions = Normal);

- // Whether layer's compositedLayerMapping needs a GraphicsLayer to do clipping by an ancestor (non-stacking-context parent with overflow).

- bool clippedByAncestor(const RenderLayer*) const;

+ // Returns whether this layer is clipped by another layer that is not an ancestor of the given layer in the stacking context hierarchy.

+ bool clippedByNonAncestorInStackingTree(const RenderLayer*) const;

// Whether layer's compositedLayerMapping needs a GraphicsLayer to clip z-order children of the given RenderLayer.

bool clipsCompositingDescendants(const RenderLayer*) const;