Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: Source/core/rendering/compositing/RenderLayerCompositor.h

Issue 266473009: Fix & clarify some comments in compositing. Rename clippedByAncestor to more accurately (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make conditionals clearer in shouldClipCompositedBounds Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 107
108 enum UpdateLayerCompositingStateOptions { 108 enum UpdateLayerCompositingStateOptions {
109 Normal, 109 Normal,
110 UseChickenEggHacks, // Use this to trigger temporary chicken-egg hacks. See crbug.com/339892. 110 UseChickenEggHacks, // Use this to trigger temporary chicken-egg hacks. See crbug.com/339892.
111 }; 111 };
112 112
113 // Update the compositing dirty bits, based on the compositing-impacting pro perties of the layer. 113 // Update the compositing dirty bits, based on the compositing-impacting pro perties of the layer.
114 // (At the moment, it also has some legacy compatibility hacks.) 114 // (At the moment, it also has some legacy compatibility hacks.)
115 void updateLayerCompositingState(RenderLayer*, UpdateLayerCompositingStateOp tions = Normal); 115 void updateLayerCompositingState(RenderLayer*, UpdateLayerCompositingStateOp tions = Normal);
116 116
117 // Whether layer's compositedLayerMapping needs a GraphicsLayer to do clippi ng by an ancestor (non-stacking-context parent with overflow). 117 // Returns whether this layer is clipped by another layer that is not an anc estor of the given layer in the stacking context hierarchy.
118 bool clippedByAncestor(const RenderLayer*) const; 118 bool clippedByNonAncestorInStackingTree(const RenderLayer*) const;
119 // Whether layer's compositedLayerMapping needs a GraphicsLayer to clip z-or der children of the given RenderLayer. 119 // Whether layer's compositedLayerMapping needs a GraphicsLayer to clip z-or der children of the given RenderLayer.
120 bool clipsCompositingDescendants(const RenderLayer*) const; 120 bool clipsCompositingDescendants(const RenderLayer*) const;
121 121
122 // Whether the given layer needs an extra 'contents' layer. 122 // Whether the given layer needs an extra 'contents' layer.
123 bool needsContentsCompositingLayer(const RenderLayer*) const; 123 bool needsContentsCompositingLayer(const RenderLayer*) const;
124 124
125 bool supportsFixedRootBackgroundCompositing() const; 125 bool supportsFixedRootBackgroundCompositing() const;
126 bool needsFixedRootBackgroundLayer(const RenderLayer*) const; 126 bool needsFixedRootBackgroundLayer(const RenderLayer*) const;
127 GraphicsLayer* fixedRootBackgroundLayer() const; 127 GraphicsLayer* fixedRootBackgroundLayer() const;
128 void setNeedsUpdateFixedBackground() { m_needsUpdateFixedBackground = true; } 128 void setNeedsUpdateFixedBackground() { m_needsUpdateFixedBackground = true; }
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 OwnPtr<GraphicsLayer> m_layerForVerticalScrollbar; 356 OwnPtr<GraphicsLayer> m_layerForVerticalScrollbar;
357 OwnPtr<GraphicsLayer> m_layerForScrollCorner; 357 OwnPtr<GraphicsLayer> m_layerForScrollCorner;
358 #if USE(RUBBER_BANDING) 358 #if USE(RUBBER_BANDING)
359 OwnPtr<GraphicsLayer> m_layerForOverhangShadow; 359 OwnPtr<GraphicsLayer> m_layerForOverhangShadow;
360 #endif 360 #endif
361 }; 361 };
362 362
363 } // namespace WebCore 363 } // namespace WebCore
364 364
365 #endif // RenderLayerCompositor_h 365 #endif // RenderLayerCompositor_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698