Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2664253002: Revert "Blink handle selection handle visibility" (Closed)

Created:
3 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org, dtapuska+blinkwatch_chromium.org, yusukes+watch_chromium.org, kinuko+watch, Navid Zolghadr, shuchen+watch_chromium.org, donnd+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, twellington+watch_chromium.org, darin-cc_chromium.org, agrieve+watch_chromium.org, blink-reviews, kalyank, cc-bugs_chromium.org, James Su, danakj+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert "Blink handle selection handle visibility" This reverts commit 1107a295dcee2f4ee3f6c24f836c6adfa7b3830d directly off M57 branch to address selection regressions (long-term fix being worked on on trunk). BUG=686700, 682128, 633281 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2664253002 . Cr-Commit-Position: refs/branch-heads/2987@{#226} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/4a0edccbd81c94be848c35be0c541dda6d015d84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+880 lines, -529 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -9 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java View 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 8 chunks +14 lines, -13 lines 0 comments Download
M content/browser/renderer_host/input/touch_selection_controller_client_aura.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc View 2 chunks +77 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 3 chunks +20 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_event_handler.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/data/touch_selection.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 4 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 6 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.h View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 15 chunks +26 lines, -68 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 6 chunks +23 lines, -182 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 8 chunks +135 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/composited_selection_bounds_basic.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/composited_selection_bounds_editable_div.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/web/tests/data/composited_selection_bounds_empty_editable_area.html View 1 chunk +3 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/web/tests/data/composited_selection_bounds_empty_editable_div.html View 2 chunks +2 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/composited_selection_bounds_empty_editable_input.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/composited_selection_bounds_empty_layer.html View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/composited_selection_bounds_iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/data/composited_selection_bounds_transformed.html View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/touch_selection/selection_event_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/touch_selection/touch_selection_controller.h View 8 chunks +34 lines, -9 lines 0 comments Download
M ui/touch_selection/touch_selection_controller.cc View 11 chunks +136 lines, -24 lines 0 comments Download
M ui/touch_selection/touch_selection_controller_unittest.cc View 35 chunks +291 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
aelias_OOO_until_Jul13
3 years, 10 months ago (2017-01-31 18:25:21 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4a0edccbd81c94be848c35be0c541dda6d015d84.

Powered by Google App Engine
This is Rietveld 408576698