Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2664253002: Revert "Blink handle selection handle visibility" (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index dcd0e286c03374c26c75dfe039b42498ca3fe071..ddbf5a24e16da5ccc3ef91266479932d20d5bb42 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -933,8 +933,8 @@ void RenderWidgetHostViewAura::OnSwapCompositorFrame(
delegated_frame_host_->SwapDelegatedFrame(compositor_frame_sink_id,
std::move(frame));
}
- selection_controller_->OnSelectionBoundsChanged(selection.start,
- selection.end);
+ SelectionUpdated(selection.is_editable, selection.is_empty_text_form_control,
+ selection.start, selection.end);
}
void RenderWidgetHostViewAura::ClearCompositorFrame() {
@@ -2237,6 +2237,16 @@ void RenderWidgetHostViewAura::ForwardKeyboardEvent(
target_host->ForwardKeyboardEvent(event);
}
+void RenderWidgetHostViewAura::SelectionUpdated(
+ bool is_editable,
+ bool is_empty_text_form_control,
+ const gfx::SelectionBound& start,
+ const gfx::SelectionBound& end) {
+ selection_controller_->OnSelectionEditable(is_editable);
+ selection_controller_->OnSelectionEmpty(is_empty_text_form_control);
+ selection_controller_->OnSelectionBoundsChanged(start, end);
+}
+
void RenderWidgetHostViewAura::CreateSelectionController() {
ui::TouchSelectionController::Config tsc_config;
tsc_config.max_tap_duration = base::TimeDelta::FromMilliseconds(

Powered by Google App Engine
This is Rietveld 408576698