Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2664253002: Revert "Blink handle selection handle visibility" (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1950 matching lines...) Expand 10 before | Expand all | Expand 10 after
1961 layoutViewItem.layer()->setNeedsCompositingInputsUpdate(); 1961 layoutViewItem.layer()->setNeedsCompositingInputsUpdate();
1962 } 1962 }
1963 } 1963 }
1964 1964
1965 bool FrameView::computeCompositedSelection(LocalFrame& frame, 1965 bool FrameView::computeCompositedSelection(LocalFrame& frame,
1966 CompositedSelection& selection) { 1966 CompositedSelection& selection) {
1967 if (!frame.view() || frame.view()->shouldThrottleRendering()) 1967 if (!frame.view() || frame.view()->shouldThrottleRendering())
1968 return false; 1968 return false;
1969 1969
1970 const VisibleSelection& visibleSelection = frame.selection().selection(); 1970 const VisibleSelection& visibleSelection = frame.selection().selection();
1971 if (visibleSelection.isNone() || !frame.selection().isHandleVisible()) 1971 if (visibleSelection.isNone())
1972 return false; 1972 return false;
1973 1973
1974 // Non-editable caret selections lack any kind of UI affordance, and 1974 // Non-editable caret selections lack any kind of UI affordance, and
1975 // needn't be tracked by the client. 1975 // needn't be tracked by the client.
1976 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable()) 1976 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
1977 return false; 1977 return false;
1978 1978
1979 VisiblePosition visibleStart(visibleSelection.visibleStart()); 1979 VisiblePosition visibleStart(visibleSelection.visibleStart());
1980 RenderedPosition renderedStart(visibleStart); 1980 RenderedPosition renderedStart(visibleStart);
1981 renderedStart.positionInGraphicsLayerBacking(selection.start, true); 1981 renderedStart.positionInGraphicsLayerBacking(selection.start, true);
(...skipping 3049 matching lines...) Expand 10 before | Expand all | Expand 10 after
5031 std::unique_ptr<CompositorAnimationTimeline> timeline) { 5031 std::unique_ptr<CompositorAnimationTimeline> timeline) {
5032 m_animationTimeline = std::move(timeline); 5032 m_animationTimeline = std::move(timeline);
5033 } 5033 }
5034 5034
5035 void FrameView::setAnimationHost( 5035 void FrameView::setAnimationHost(
5036 std::unique_ptr<CompositorAnimationHost> host) { 5036 std::unique_ptr<CompositorAnimationHost> host) {
5037 m_animationHost = std::move(host); 5037 m_animationHost = std::move(host);
5038 } 5038 }
5039 5039
5040 } // namespace blink 5040 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698