Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2664253002: Revert "Blink handle selection handle visibility" (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index 71dd26ba379e6b1dd0030195bb86d3d6e4782e43..12b7584427b121a3be1338974540a6cd2edf990c 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -66,8 +66,6 @@ enum class SelectionDirectionalMode { NonDirectional, Directional };
enum class CaretVisibility;
-enum class HandleVisibility { NotVisible, Visible };
-
class CORE_EXPORT FrameSelection final
: public GarbageCollectedFinalized<FrameSelection> {
WTF_MAKE_NONCOPYABLE(FrameSelection);
@@ -87,7 +85,6 @@ class CORE_EXPORT FrameSelection final
DoNotUpdateAppearance = 1 << 4,
DoNotClearStrategy = 1 << 5,
DoNotAdjustInFlatTree = 1 << 6,
- HandleVisible = 1 << 7,
};
// Union of values in SetSelectionOption and EUserTriggered
typedef unsigned SetSelectionOptions;
@@ -238,11 +235,6 @@ class CORE_EXPORT FrameSelection final
void pageActivationChanged();
void setUseSecureKeyboardEntryWhenActive(bool);
-
- bool isHandleVisible() const {
- return m_handleVisibility == HandleVisibility::Visible;
- }
-
void updateSecureKeyboardEntryIfActive();
// Returns true if a word is selected.
@@ -347,8 +339,6 @@ class CORE_EXPORT FrameSelection final
bool m_focused : 1;
- HandleVisibility m_handleVisibility = HandleVisibility::NotVisible;
-
// Controls text granularity used to adjust the selection's extent in
// moveRangeSelectionExtent.
std::unique_ptr<GranularityStrategy> m_granularityStrategy;

Powered by Google App Engine
This is Rietveld 408576698