Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 2664093002: Send orientation change events to sub frames even if parent isn't active. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Send orientation change events to sub frames even if parent isn't active. When a frame receive an orientatio change notification, it only carry the notification over if it is active but the iframe might be listening to the event and not the frame. Unfortunately, the test checking this was subtly broken because it initialised itself by looking for the current orientation, thus initialising the top frame controller. BUG=682441 Review-Url: https://codereview.chromium.org/2661663003 Cr-Commit-Position: refs/heads/master@{#446834} (cherry picked from commit 1c17214f719b1e715aa6c64848c87176c2ac90b0) Review-Url: https://codereview.chromium.org/2664093002 . Cr-Commit-Position: refs/branch-heads/2987@{#210} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/80b7f9b6005cc57cfb71797bb4edb8220a8717f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/screen_orientation/orientationchange-event-subframe.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp View 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mlamouri (slow - plz ping)
3 years, 10 months ago (2017-01-31 02:38:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80b7f9b6005cc57cfb71797bb4edb8220a8717f7.

Powered by Google App Engine
This is Rietveld 408576698