third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h - Issue 2664093002: Send orientation change events to sub frames even if parent isn't active.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

Issue 2664093002: Send orientation change events to sub frames even if parent isn't active. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/screen_orientation/orientationchange-event-subframe.html ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ScreenOrientationControllerImpl_h	5 #ifndef ScreenOrientationControllerImpl_h

6 #define ScreenOrientationControllerImpl_h	6 #define ScreenOrientationControllerImpl_h

7	7

8 #include "core/dom/Document.h"	8 #include "core/dom/Document.h"

9 #include "core/frame/PlatformEventController.h"	9 #include "core/frame/PlatformEventController.h"

10 #include "core/frame/ScreenOrientationController.h"	10 #include "core/frame/ScreenOrientationController.h"

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 // Inherited from ContextLifecycleObserver and PageVisibilityObserver.	58 // Inherited from ContextLifecycleObserver and PageVisibilityObserver.

59 void contextDestroyed(ExecutionContext*) override;	59 void contextDestroyed(ExecutionContext*) override;

60 void pageVisibilityChanged() override;	60 void pageVisibilityChanged() override;

61	61

62 void notifyDispatcher();	62 void notifyDispatcher();

63	63

64 void updateOrientation();	64 void updateOrientation();

65	65

66 void dispatchEventTimerFired(TimerBase*);	66 void dispatchEventTimerFired(TimerBase*);

67	67

	68 bool isActive() const;

	69 bool isVisible() const;

68 bool isActiveAndVisible() const;	70 bool isActiveAndVisible() const;

69	71

70 Member<ScreenOrientation> m_orientation;	72 Member<ScreenOrientation> m_orientation;

71 WebScreenOrientationClient* m_client;	73 WebScreenOrientationClient* m_client;

72 Timer<ScreenOrientationControllerImpl> m_dispatchEventTimer;	74 Timer<ScreenOrientationControllerImpl> m_dispatchEventTimer;

73 bool m_activeLock = false;	75 bool m_activeLock = false;

74 };	76 };

75	77

76 } // namespace blink	78 } // namespace blink

77	79

78 #endif // ScreenOrientationControllerImpl_h	80 #endif // ScreenOrientationControllerImpl_h

OLD	NEW