third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h - Issue 2664093002: Send orientation change events to sub frames even if parent isn't active.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

Issue 2664093002: Send orientation change events to sub frames even if parent isn't active. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/screen_orientation/orientationchange-event-subframe.html ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

index 72ca677d880840c2123b3e7c3a06aa7e509238c3..90fcfdebbeb063070fefb67a084ad35150f4c152 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

@@ -65,6 +65,8 @@ class MODULES_EXPORT ScreenOrientationControllerImpl final

void dispatchEventTimerFired(TimerBase*);

+ bool isActive() const;

+ bool isVisible() const;

bool isActiveAndVisible() const;

Member<ScreenOrientation> m_orientation;