Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2661663003: Send orientation change events to sub frames even if parent isn't active. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews, haraken, mlamouri+watch-screen-orientation_chromium.org, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send orientation change events to sub frames even if parent isn't active. When a frame receive an orientatio change notification, it only carry the notification over if it is active but the iframe might be listening to the event and not the frame. Unfortunately, the test checking this was subtly broken because it initialised itself by looking for the current orientation, thus initialising the top frame controller. BUG=682441 Review-Url: https://codereview.chromium.org/2661663003 Cr-Commit-Position: refs/heads/master@{#446834} Committed: https://chromium.googlesource.com/chromium/src/+/1c17214f719b1e715aa6c64848c87176c2ac90b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/screen_orientation/orientationchange-event-subframe.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp View 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mlamouri (slow - plz ping)
PTAL :)
3 years, 10 months ago (2017-01-27 20:20:32 UTC) #4
eae
Thanks for fixing this LGTM
3 years, 10 months ago (2017-01-27 20:21:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661663003/1
3 years, 10 months ago (2017-01-27 23:36:47 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 23:46:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c17214f719b1e715aa6c64848c8...

Powered by Google App Engine
This is Rietveld 408576698