Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2663973002: [inspector] added experimental is_module flag for script parsed events (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
dgozman, adamk, Yang
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added experimental is_module flag for script parsed events This flag is true when compiled script is ES6 module. BUG=v8:1569 R=dgozman@chromium.org,adamk@chromium.org Review-Url: https://codereview.chromium.org/2663973002 Cr-Commit-Position: refs/heads/master@{#42910} Committed: https://chromium.googlesource.com/v8/v8/+/9c7da663f93df1e6fa8a9e899f2bacbe2b7f8d8e

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -8 lines) Patch
M src/api.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/debug/debug-interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/js_protocol.json View 2 chunks +4 lines, -2 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/inspector/v8-debugger-script.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/v8-debugger-script.cc View 3 chunks +5 lines, -0 lines 0 comments Download
A test/inspector/debugger/es6-module-script-parsed.js View 1 chunk +28 lines, -0 lines 0 comments Download
A test/inspector/debugger/es6-module-script-parsed-expected.txt View 1 chunk +55 lines, -0 lines 0 comments Download
M test/inspector/debugger/script-on-after-compile-expected.txt View 39 chunks +39 lines, -0 lines 0 comments Download
M test/inspector/debugger/script-parsed-for-runtime-evaluate-expected.txt View 6 chunks +6 lines, -0 lines 0 comments Download
M test/inspector/protocol-test.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/inspector/runtime/es6-module.js View 1 chunk +1 line, -4 lines 0 comments Download
M test/inspector/runtime/es6-module-expected.txt View 4 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
kozy
Dmitry and Adam, please take a look.
3 years, 10 months ago (2017-01-30 23:42:03 UTC) #1
dgozman
lgtm
3 years, 10 months ago (2017-02-03 01:07:48 UTC) #2
kozy
Yang, I need your owner lgtm for debug-interface.h, please take a look.
3 years, 10 months ago (2017-02-03 01:13:58 UTC) #4
Yang
On 2017/02/03 01:13:58, kozy wrote: > Yang, I need your owner lgtm for debug-interface.h, please ...
3 years, 10 months ago (2017-02-03 06:46:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663973002/20001
3 years, 10 months ago (2017-02-03 06:47:02 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 07:17:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9c7da663f93df1e6fa8a9e899f2bacbe2b7...

Powered by Google App Engine
This is Rietveld 408576698