Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2663743002: [inspector] added test infrastructure and test for es6 modules (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
alph, dgozman, adamk
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added test infrastructure and test for es6 modules Test just checks that all basic features are working correctly with modules. BUG=v8:1569 R=dgozman@chromium.org,alph@chromium.org,adamk@chromium.org Review-Url: https://codereview.chromium.org/2663743002 Cr-Commit-Position: refs/heads/master@{#42796} Committed: https://chromium.googlesource.com/v8/v8/+/d6db11fd181061f9ffce4431af5afec0dba2c82c

Patch Set 1 #

Total comments: 5

Patch Set 2 : addressed comments #

Patch Set 3 : fixed crash #

Total comments: 3

Patch Set 4 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -44 lines) Patch
M src/ast/scopes.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M test/inspector/debugger/get-possible-breakpoints.js View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/debugger/get-possible-breakpoints-array-literal.js View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/inspector-test.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M test/inspector/protocol-test.js View 1 chunk +9 lines, -5 lines 0 comments Download
A test/inspector/runtime/es6-module.js View 1 1 chunk +64 lines, -0 lines 0 comments Download
A test/inspector/runtime/es6-module-expected.txt View 1 1 chunk +236 lines, -0 lines 0 comments Download
M test/inspector/task-runner.h View 6 chunks +27 lines, -3 lines 0 comments Download
M test/inspector/task-runner.cc View 1 6 chunks +53 lines, -25 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
kozy
In this CL one test of existing features with modules is added, one-page proposal for ...
3 years, 10 months ago (2017-01-30 08:18:26 UTC) #1
dgozman
inspector lgtm, but I cannot check the modules usage itself. https://codereview.chromium.org/2663743002/diff/1/test/inspector/runtime/module.js File test/inspector/runtime/module.js (right): https://codereview.chromium.org/2663743002/diff/1/test/inspector/runtime/module.js#newcode5 ...
3 years, 10 months ago (2017-01-30 19:42:09 UTC) #2
adamk
lgtm seems good for a start, thanks!
3 years, 10 months ago (2017-01-30 20:56:59 UTC) #3
kozy
all done. https://codereview.chromium.org/2663743002/diff/1/test/inspector/runtime/module.js File test/inspector/runtime/module.js (right): https://codereview.chromium.org/2663743002/diff/1/test/inspector/runtime/module.js#newcode5 test/inspector/runtime/module.js:5: print('Checks basic ES6 modules support.'); On 2017/01/30 ...
3 years, 10 months ago (2017-01-30 21:23:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663743002/20001
3 years, 10 months ago (2017-01-30 21:24:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21769) v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-01-30 21:42:29 UTC) #10
kozy
Adam, please take another look. https://codereview.chromium.org/2663743002/diff/40001/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2663743002/diff/40001/src/ast/scopes.cc#newcode1888 src/ast/scopes.cc:1888: if (is_module_scope()) AsModuleScope()->AllocateModuleVariables(); Adam, ...
3 years, 10 months ago (2017-01-30 23:25:11 UTC) #13
adamk
https://codereview.chromium.org/2663743002/diff/40001/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2663743002/diff/40001/src/ast/scopes.cc#newcode1888 src/ast/scopes.cc:1888: if (is_module_scope()) AsModuleScope()->AllocateModuleVariables(); On 2017/01/30 23:25:11, kozy wrote: > ...
3 years, 10 months ago (2017-01-30 23:34:35 UTC) #14
kozy
https://codereview.chromium.org/2663743002/diff/40001/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2663743002/diff/40001/src/ast/scopes.cc#newcode1888 src/ast/scopes.cc:1888: if (is_module_scope()) AsModuleScope()->AllocateModuleVariables(); On 2017/01/30 23:34:35, adamk wrote: > ...
3 years, 10 months ago (2017-01-30 23:40:40 UTC) #15
adamk
lgtm
3 years, 10 months ago (2017-01-30 23:44:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663743002/60001
3 years, 10 months ago (2017-01-31 00:18:04 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 00:19:49 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/d6db11fd181061f9ffce4431af5afec0dba...

Powered by Google App Engine
This is Rietveld 408576698