[inspector] return meaningful error on Debug.setScriptSource for ES module

[inspector] return meaningful error on Debug.setScriptSource for ES module

BUG=v8:1569
R=dgozman@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2669713002
Cr-Commit-Position: refs/heads/master@{#42935}
Committed: https://chromium.googlesource.com/v8/v8/+/6b6ed60155314fc608504b235382909ebedc23d8

[kozy, 2017-02-01 04:44:37]

Aleksey or Dmitry, please take a look.

[dgozman, 2017-02-03 20:57:25]

lgtm

https://codereview.chromium.org/2669713002/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2669713002/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:530: return Response::Error("No script
for id: " + scriptId);
No script with given id found

https://codereview.chromium.org/2669713002/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:535: "Debugger.setScriptSource doesn't
support editing ES module");
Editing module's script is not supported.

[kozy, 2017-02-03 21:32:55]

all done! thanks!

https://codereview.chromium.org/2669713002/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2669713002/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:530: return Response::Error("No script
for id: " + scriptId);
On 2017/02/03 20:57:25, dgozman (OOO till Feb 13) wrote:
> No script with given id found

Done.

https://codereview.chromium.org/2669713002/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:535: "Debugger.setScriptSource doesn't
support editing ES module");
On 2017/02/03 20:57:25, dgozman (OOO till Feb 13) wrote:
> Editing module's script is not supported.

Done.

[kozy, 2017-02-03 21:32:58]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-03 21:32:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2669713002/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-02-03 21:33:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 22:10:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486157578605130,
"parent_rev": "51ed12f96e5700b7ca5a89729574c719835a46d7", "commit_rev":
"6b6ed60155314fc608504b235382909ebedc23d8"}

[commit-bot: I haz the power, 2017-02-03 22:10:10]

Description was changed from

==========
[inspector] return meaningful error on Debug.setScriptSource for ES module

BUG=v8:1569
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] return meaningful error on Debug.setScriptSource for ES module

BUG=v8:1569
R=dgozman@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2669713002
Cr-Commit-Position: refs/heads/master@{#42935}
Committed:
https://chromium.googlesource.com/v8/v8/+/6b6ed60155314fc608504b235382909ebed...
==========

[commit-bot: I haz the power, 2017-02-03 22:10:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/6b6ed60155314fc608504b235382909ebed...