Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: src/inspector/v8-debugger-script.cc

Issue 2663973002: [inspector] added experimental is_module flag for script parsed events (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger-script.h ('k') | test/inspector/debugger/es6-module-script-parsed.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-script.cc
diff --git a/src/inspector/v8-debugger-script.cc b/src/inspector/v8-debugger-script.cc
index f19dd8118ce66ed7cc4c86f7ecaf8d4f513f04ff..200cdc71a26da41ae8bba76d30144ad5a2eca0f7 100644
--- a/src/inspector/v8-debugger-script.cc
+++ b/src/inspector/v8-debugger-script.cc
@@ -142,10 +142,13 @@ class ActualScript : public V8DebuggerScript {
}
}
+ m_isModule = script->IsModule();
+
m_script.Reset(m_isolate, script);
}
bool isLiveEdit() const override { return m_isLiveEdit; }
+ bool isModule() const override { return m_isModule; }
const String16& sourceMappingURL() const override {
return m_sourceMappingURL;
@@ -191,6 +194,7 @@ class ActualScript : public V8DebuggerScript {
String16 m_sourceMappingURL;
v8::Global<v8::String> m_sourceObj;
bool m_isLiveEdit = false;
+ bool m_isModule = false;
v8::Global<v8::debug::Script> m_script;
};
@@ -219,6 +223,7 @@ class WasmVirtualScript : public V8DebuggerScript {
const String16& sourceMappingURL() const override { return emptyString(); }
bool isLiveEdit() const override { return false; }
+ bool isModule() const override { return false; }
void setSourceMappingURL(const String16&) override {}
bool getPossibleBreakpoints(
« no previous file with comments | « src/inspector/v8-debugger-script.h ('k') | test/inspector/debugger/es6-module-script-parsed.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698