Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 266203003: Infrastructure changes to support pull saveLayers forward task (Closed)

Created:
6 years, 7 months ago by robertphillips
Modified:
6 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Infrastructure changes to support pull-saveLayers-forward task This is split out of (First pass at pre-rendering saveLayers for GPU - https://codereview.chromium.org/261663003/). It mainly: Moves NeedsDeepCopy to somewhere more accessible (so GrPictureUtils.cpp can use it) Moves ComputeAccelDataKey somewhere more accessible (so GPUPicture test can use it) Adds unit test for picture saveLayer analysis (done in EXPERIMENTAL_optimize) Adds new fields to SaveLayerInfo that are needed to pull forward layers Committed: http://code.google.com/p/skia/source/detail?r=14571 Committed: http://code.google.com/p/skia/source/detail?r=14586

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed Android error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -72 lines) Patch
M src/core/SkPaintPriv.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 1 1 chunk +21 lines, -0 lines 0 comments Download
M src/core/SkPicture.cpp View 1 3 chunks +2 lines, -21 lines 0 comments Download
M src/gpu/GrPictureUtils.h View 1 3 chunks +19 lines, -0 lines 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 7 chunks +45 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 5 chunks +2 lines, -47 lines 0 comments Download
M tests/PictureTest.cpp View 1 4 chunks +150 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
6 years, 7 months ago (2014-05-05 16:15:28 UTC) #1
bsalomon
lgtm https://codereview.chromium.org/266203003/diff/1/src/gpu/GrPictureUtils.h File src/gpu/GrPictureUtils.h (right): https://codereview.chromium.org/266203003/diff/1/src/gpu/GrPictureUtils.h#newcode43 src/gpu/GrPictureUtils.h:43: bool fIsNested; maybe a depth integer value?
6 years, 7 months ago (2014-05-05 17:38:35 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 7 months ago (2014-05-05 17:59:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/266203003/1
6 years, 7 months ago (2014-05-05 18:00:04 UTC) #4
commit-bot: I haz the power
Change committed as 14571
6 years, 7 months ago (2014-05-05 18:06:18 UTC) #5
robertphillips
This was reverted in r14578 due to breaking Android unit tests
6 years, 7 months ago (2014-05-05 19:24:45 UTC) #6
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 7 months ago (2014-05-06 11:56:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/266203003/20001
6 years, 7 months ago (2014-05-06 11:56:40 UTC) #8
commit-bot: I haz the power
Change committed as 14586
6 years, 7 months ago (2014-05-06 12:02:26 UTC) #9
mtklein
6 years, 7 months ago (2014-05-06 12:54:20 UTC) #10
Message was sent while issue was closed.
On 2014/05/06 12:02:26, I haz the power (commit-bot) wrote:
> Change committed as 14586

:(  Valgrind says the new test is leaking:
http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-...

Powered by Google App Engine
This is Rietveld 408576698