Generate better catalog C++ sources

Generate better catalog C++ sources

Rather than dumping a simple string literal, which has unacceptable
limitations due to arbitrary string literal length constraints in
compilers, we instead parse the JSON at build time and emit a C++
function which returns a fixed base::Value representation of that JSON.

BUG=685359
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2659523002
Cr-Commit-Position: refs/heads/master@{#446404}
Committed: https://chromium.googlesource.com/chromium/src/+/72cb24d232fb79d878f8c0ab16b736e207d9c355

[Ken Rockot(use gerrit already), 2017-01-26 01:48:50]

Description was changed from

==========
Generate better catalog C++ sources

Rather than dumping a simple string literal, which has unacceptable
limitations due to arbitrary string literal length constraints in
compilers, we instead parse the JSON at build time and emit a C++
function which emits a base::Value representation of that JSON.

BUG=685359
R=ben@chromium.org
==========

to

==========
Generate better catalog C++ sources

Rather than dumping a simple string literal, which has unacceptable
limitations due to arbitrary string literal length constraints in
compilers, we instead parse the JSON at build time and emit a C++
function which returns a fixed base::Value representation of that JSON.

BUG=685359
R=ben@chromium.org
==========

[Ben Goodger (Google), 2017-01-26 05:17:33]

I mean at a certain point we may as well emit a catalog::Entry... but sure :-)
I'm sure I'll have fun with this the next time I try and adjust the format.

lgtm

[Ken Rockot(use gerrit already), 2017-01-26 05:34:10]

Right, I started going down the path of defining real types for these
things, but it just made for a larger CL.

On Wed, Jan 25, 2017 at 9:17 PM, <ben@chromium.org> wrote:

> I mean at a certain point we may as well emit a catalog::Entry... but sure
> :-)
> I'm sure I'll have fun with this the next time I try and adjust the format.
>
> lgtm
>
> https://codereview.chromium.org/2659523002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2017-01-26 18:28:49]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-01-26 18:29:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 19:47:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485455329413350, "parent_rev":
"ed00b16cf9ab2a6321b78d6ee274bbf73a63ae6a", "commit_rev":
"72cb24d232fb79d878f8c0ab16b736e207d9c355"}

[commit-bot: I haz the power, 2017-01-26 19:48:30]

Description was changed from

==========
Generate better catalog C++ sources

Rather than dumping a simple string literal, which has unacceptable
limitations due to arbitrary string literal length constraints in
compilers, we instead parse the JSON at build time and emit a C++
function which returns a fixed base::Value representation of that JSON.

BUG=685359
R=ben@chromium.org
==========

to

==========
Generate better catalog C++ sources

Rather than dumping a simple string literal, which has unacceptable
limitations due to arbitrary string literal length constraints in
compilers, we instead parse the JSON at build time and emit a C++
function which returns a fixed base::Value representation of that JSON.

BUG=685359
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2659523002
Cr-Commit-Position: refs/heads/master@{#446404}
Committed:
https://chromium.googlesource.com/chromium/src/+/72cb24d232fb79d878f8c0ab16b7...
==========

[commit-bot: I haz the power, 2017-01-26 19:48:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72cb24d232fb79d878f8c0ab16b7...