Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2654173002: Revert to using on-disk catalog manifest for views mus tests (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert to using on-disk catalog manifest for views mus tests This catalog is too large to fit into a string constant under certain MSVS configurations. We'll need an alternative way to generate the manifest sources. BUG=685359 TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2654173002 Cr-Commit-Position: refs/heads/master@{#446230} Committed: https://chromium.googlesource.com/chromium/src/+/54f7f1152bc29db13f40cf6c013f1334fc257a02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M ui/views/mus/BUILD.gn View 5 chunks +11 lines, -4 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654173002/1
3 years, 10 months ago (2017-01-25 21:13:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220318)
3 years, 10 months ago (2017-01-26 00:00:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654173002/1
3 years, 10 months ago (2017-01-26 00:08:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220432)
3 years, 10 months ago (2017-01-26 03:33:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654173002/1
3 years, 10 months ago (2017-01-26 03:38:29 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 05:01:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54f7f1152bc29db13f40cf6c013f...

Powered by Google App Engine
This is Rietveld 408576698