Generate better catalog C++ sources

services/catalog/public/tools/catalog.gni

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/dcheck_always_on.gni")
 
 # Generates a static catalog manifest to be loaded at runtime. This manifest
 # contains the union of all individual service manifests specified by the
 # template parameters.
 #
@@ skipping 129 matching lines @@
 }
 
 # Generates a source_set target which defines a single string contstant
 # containing the contents of a compiled catalog manifest.
 #
 # Parameters:
 #
 #   catalog
 #       The catalog target whose output should be stringified.
 #
-#   output_symbol_name
+#   generated_function_name
 #       The fully qualified symbol name of the C++ string constant to define in
 #       the generate source_set.
 #
 template("catalog_cpp_source") {
   assert(defined(invoker.catalog), "catalog is required")
-  assert(defined(invoker.output_symbol_name), "output_symbol_name is required")
+  assert(defined(invoker.generated_function_name),
+         "generated_function_name is required")
 
   catalog_target = invoker.catalog
   catalog_target_dir = get_label_info(catalog_target, "target_gen_dir")
   catalog_target_name = get_label_info(catalog_target, "name")
   catalog_filename = "$catalog_target_dir/${catalog_target_name}.json"
 
   generator_target_name = "${target_name}__generator"
-  generated_filename = "${target_gen_dir}/${target_name}.cc"
+  generated_filename_base = "${target_gen_dir}/${target_name}"
 
   action(generator_target_name) {
     testonly = defined(invoker.testonly) && invoker.testonly
     script = "//services/catalog/public/tools/sourcify_manifest.py"
     inputs = [
       catalog_filename,
+
+      "//services/catalog/public/tools/catalog.cc.tmpl",
+      "//services/catalog/public/tools/catalog.h.tmpl",
     ]
     outputs = [
-      generated_filename,
+      "${generated_filename_base}.cc",
+      "${generated_filename_base}.h",
     ]
     args = [
       "--input=" + rebase_path(catalog_filename, root_build_dir),
-      "--output=" + rebase_path(generated_filename, root_build_dir),
-      "--symbol-name=" + invoker.output_symbol_name,
+      "--output-filename-base=" +
+          rebase_path(generated_filename_base, root_build_dir),
+      "--output-function-name=" + invoker.generated_function_name,
+      "--module-path=" + rebase_path(generated_filename_base, root_gen_dir),
     ]
     if (is_debug || dcheck_always_on) {
       args += [ "--pretty" ]
     }
     deps = [
       catalog_target,
     ]
   }
 
   source_set(target_name) {
     testonly = defined(invoker.testonly) && invoker.testonly
     sources = get_target_outputs(":$generator_target_name")
     deps = [
       ":$generator_target_name",
+      "//base",
     ]
   }
 }