Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: services/service_manager/public/cpp/test/service_test_catalog.h

Issue 2659523002: Generate better catalog C++ sources (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/public/cpp/test/service_test_catalog.h
diff --git a/services/service_manager/public/cpp/test/service_test_catalog.h b/services/service_manager/public/cpp/test/service_test_catalog.h
index 2a627c265f4f4f9ae5d8ee07bfa3050f2f0d33ae..fa98ea0726fa5b8fe23ac4b8aaf0a3b21e63c783 100644
--- a/services/service_manager/public/cpp/test/service_test_catalog.h
+++ b/services/service_manager/public/cpp/test/service_test_catalog.h
@@ -2,17 +2,28 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#ifndef SERVICES_SERVICE_MANAGER_PUBLIC_CPP_TEST_SERVICE_TEST_CATALOG_H_
+#define SERVICES_SERVICE_MANAGER_PUBLIC_CPP_TEST_SERVICE_TEST_CATALOG_H_
+
+#include <memory>
+
+namespace base {
+class Value;
+}
+
namespace service_manager {
namespace test {
-// This symbol must be defined by any target linking against the
+// This function must be defined by any target linking against the
// ":run_all_service_tests" target in this directory. Use the service_test
// GN template defined in
// src/services/service_manager/public/tools/test/service_test.gni to
-// autogenerate and link against a definition of the symbol dervied from the
-// contents of a generated service catalog. See the service_test.gni
-// documentation for more details.
-extern const char kServiceTestCatalog[];
+// autogenerate and link against a definition of the function generated from the
+// contents of a catalog manifest. See the service_test.gni documentation for
+// more details.
+std::unique_ptr<base::Value> CreateTestCatalog();
} // namespace test
} // namespace service_manager
+
+#endif // SERVICES_SERVICE_MANAGER_PUBLIC_CPP_TEST_SERVICE_TEST_CATALOG_H_

Powered by Google App Engine
This is Rietveld 408576698