[RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

[RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

For frame-level scrolls, the PLSA for the root layer is added to its
FrameView's scrollable area set.  This means that it's not necessary
(or correct) to add a child FrameView to its parent FrameView's
scrollable area set.

BUG=417782
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2659183002
Cr-Commit-Position: refs/heads/master@{#447333}
Committed: https://chromium.googlesource.com/chromium/src/+/8695fd0d750ac19e8d78263a93e0fec6f446a6f6

[szager1, 2017-01-28 00:26:57]

Description was changed from

==========
[RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

For frame-level scrolls, the PLSA for the root layer is added to its
FrameView's scrollable area set.  This means that it's not necessary
(or correct) to add a child FrameView to its parent FrameView's
scrollable area set.

BUG=417782
R=skobes@chromium.org
==========

to

==========
[RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

For frame-level scrolls, the PLSA for the root layer is added to its
FrameView's scrollable area set.  This means that it's not necessary
(or correct) to add a child FrameView to its parent FrameView's
scrollable area set.

BUG=417782
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[szager1, 2017-01-28 00:27:12]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 00:28:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 01:59:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 01:59:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skobes, 2017-01-28 02:00:04]

lgtm w/ nit

https://codereview.chromium.org/2659183002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js
(right):

https://codereview.chromium.org/2659183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:38:
Array.prototype.sort.call(rects, (a, b) => {
I thought of an easier way :)

Array.prototype.sort.call(rects, (a, b) => (
    a.height - b.height ||
    a.width - b.width ||
    a.top - b.top ||
    a.left - b.left));

[szager1, 2017-01-31 00:01:36]

On 2017/01/28 02:00:04, skobes wrote:
> lgtm w/ nit
> 
>
https://codereview.chromium.org/2659183002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js
> (right):
> 
>
https://codereview.chromium.org/2659183002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:38:
> Array.prototype.sort.call(rects, (a, b) => {
> I thought of an easier way :)
> 
> Array.prototype.sort.call(rects, (a, b) => (
>     a.height - b.height ||
>     a.width - b.width ||
>     a.top - b.top ||
>     a.left - b.left));

Done (after correcting the sort order :)

[szager1, 2017-01-31 19:08:19]

The CQ bit was checked by szager@chromium.org

[szager1, 2017-01-31 19:08:20]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2659183002/#ps80001
(title: "nit scratched")

[commit-bot: I haz the power, 2017-01-31 19:09:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 19:18:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:18:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[szager1, 2017-01-31 19:34:03]

Description was changed from

==========
[RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

For frame-level scrolls, the PLSA for the root layer is added to its
FrameView's scrollable area set.  This means that it's not necessary
(or correct) to add a child FrameView to its parent FrameView's
scrollable area set.

BUG=417782
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

For frame-level scrolls, the PLSA for the root layer is added to its
FrameView's scrollable area set.  This means that it's not necessary
(or correct) to add a child FrameView to its parent FrameView's
scrollable area set.

BUG=417782
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[szager1, 2017-01-31 19:34:03]

szager@chromium.org changed reviewers:
+ eae@chromium.org

[szager1, 2017-01-31 19:34:19]

+eae for platform/

[eae, 2017-01-31 19:36:21]

RS LGTM

[eae, 2017-01-31 19:36:29]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:37:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 21:26:33]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485891389366200,
"parent_rev": "0a7d6128ae9cc9610276b92784da28b8df0850e3", "commit_rev":
"8695fd0d750ac19e8d78263a93e0fec6f446a6f6"}

[commit-bot: I haz the power, 2017-01-31 21:27:13]

Description was changed from

==========
[RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

For frame-level scrolls, the PLSA for the root layer is added to its
FrameView's scrollable area set.  This means that it's not necessary
(or correct) to add a child FrameView to its parent FrameView's
scrollable area set.

BUG=417782
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

For frame-level scrolls, the PLSA for the root layer is added to its
FrameView's scrollable area set.  This means that it's not necessary
(or correct) to add a child FrameView to its parent FrameView's
scrollable area set.

BUG=417782
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2659183002
Cr-Commit-Position: refs/heads/master@{#447333}
Committed:
https://chromium.googlesource.com/chromium/src/+/8695fd0d750ac19e8d78263a93e0...
==========

[commit-bot: I haz the power, 2017-01-31 21:27:15]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8695fd0d750ac19e8d78263a93e0...