third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h - Issue 2659183002: [RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

Issue 2659183002: [RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator (Closed)

Patch Set: nit scratched Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

index 3b73e61632babca2717ee1e458440b028cd83a3d..24f17a566b162376a473503f3114f0801b4bd991 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

@@ -154,7 +154,7 @@ class CORE_EXPORT ScrollingCoordinator final

private:

bool shouldUpdateAfterCompositingChange() const {

return m_scrollGestureRegionIsDirty || m_touchEventTargetRectsAreDirty ||

- m_shouldScrollOnMainThreadDirty || frameViewIsDirty();

+ m_shouldScrollOnMainThreadDirty || frameScrollerIsDirty();

}

void setShouldUpdateScrollLayerPositionOnMainThread(

@@ -171,7 +171,7 @@ class CORE_EXPORT ScrollingCoordinator final

ScrollbarOrientation);

void removeWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation);

- bool frameViewIsDirty() const;

+ bool frameScrollerIsDirty() const;

std::unique_ptr<CompositorAnimationHost> m_animationHost;

std::unique_ptr<CompositorAnimationTimeline>