Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 2659183002: [RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator (Closed)
Patch Set: nit scratched Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 // corner is setNeedsPaintInvalidation. 312 // corner is setNeedsPaintInvalidation.
313 virtual void scrollControlWasSetNeedsPaintInvalidation() = 0; 313 virtual void scrollControlWasSetNeedsPaintInvalidation() = 0;
314 314
315 // Returns the default scroll style this area should scroll with when not 315 // Returns the default scroll style this area should scroll with when not
316 // explicitly specified. E.g. The scrolling behavior of an element can be 316 // explicitly specified. E.g. The scrolling behavior of an element can be
317 // specified in CSS. 317 // specified in CSS.
318 virtual ScrollBehavior scrollBehaviorStyle() const { 318 virtual ScrollBehavior scrollBehaviorStyle() const {
319 return ScrollBehaviorInstant; 319 return ScrollBehaviorInstant;
320 } 320 }
321 321
322 virtual bool isScrollable() const { return true; }
323
322 // TODO(bokan): FrameView::setScrollOffset uses updateScrollbars to scroll 324 // TODO(bokan): FrameView::setScrollOffset uses updateScrollbars to scroll
323 // which bails out early if its already in updateScrollbars, the effect being 325 // which bails out early if its already in updateScrollbars, the effect being
324 // that programmatic scrolls (i.e. setScrollOffset) are disabled when in 326 // that programmatic scrolls (i.e. setScrollOffset) are disabled when in
325 // updateScrollbars. Expose this here to allow RootFrameViewport to match the 327 // updateScrollbars. Expose this here to allow RootFrameViewport to match the
326 // semantics for now but it should be cleaned up at the source. 328 // semantics for now but it should be cleaned up at the source.
327 virtual bool isProgrammaticallyScrollable() { return true; } 329 virtual bool isProgrammaticallyScrollable() { return true; }
328 330
329 // Subtracts space occupied by this ScrollableArea's scrollbars. 331 // Subtracts space occupied by this ScrollableArea's scrollbars.
330 // Does nothing if overlay scrollbars are enabled. 332 // Does nothing if overlay scrollbars are enabled.
331 IntSize excludeScrollbars(const IntSize&) const; 333 IntSize excludeScrollbars(const IntSize&) const;
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 // vertical-lr / ltr NO NO 448 // vertical-lr / ltr NO NO
447 // vertical-lr / rtl NO YES 449 // vertical-lr / rtl NO YES
448 // vertical-rl / ltr YES NO 450 // vertical-rl / ltr YES NO
449 // vertical-rl / rtl YES YES 451 // vertical-rl / rtl YES YES
450 IntPoint m_scrollOrigin; 452 IntPoint m_scrollOrigin;
451 }; 453 };
452 454
453 } // namespace blink 455 } // namespace blink
454 456
455 #endif // ScrollableArea_h 457 #endif // ScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698