Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2658253003: [RootLayerScrolls] Fix ScrollingCoordinatorTest (Closed)

Created:
3 years, 10 months ago by szager1
Modified:
3 years, 10 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[RootLayerScrolls] Fix ScrollingCoordinatorTest BUG=490942 R=skobes@chromium.org Review-Url: https://codereview.chromium.org/2658253003 Cr-Commit-Position: refs/heads/master@{#447376} Committed: https://chromium.googlesource.com/chromium/src/+/f32ea8e81f35c9313818e3f57d960516df478670

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -131 lines) Patch
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 41 chunks +129 lines, -124 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/has-non-layer-viewport-constrained-objects.html View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/iframe-background-attachment-fixed-inner.html View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 2659183002 Patch 80001

Dependent Patchsets:

Issue 2662153004 Patch 1

Messages

Total messages: 10 (4 generated)
szager1
3 years, 10 months ago (2017-01-28 00:34:48 UTC) #1
skobes
lgtm w/ nit https://codereview.chromium.org/2658253003/diff/1/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp File third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp (right): https://codereview.chromium.org/2658253003/diff/1/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp#newcode107 third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp:107: GraphicsLayer* getFrameScrollLayer(LocalFrame& localFrame) { This looks ...
3 years, 10 months ago (2017-01-28 01:07:45 UTC) #2
szager1
https://codereview.chromium.org/2658253003/diff/1/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp File third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp (right): https://codereview.chromium.org/2658253003/diff/1/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp#newcode107 third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp:107: GraphicsLayer* getFrameScrollLayer(LocalFrame& localFrame) { On 2017/01/28 01:07:45, skobes wrote: ...
3 years, 10 months ago (2017-01-31 00:00:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658253003/20001
3 years, 10 months ago (2017-01-31 22:49:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f32ea8e81f35c9313818e3f57d960516df478670
3 years, 10 months ago (2017-02-01 00:07:57 UTC) #9
johnme
3 years, 10 months ago (2017-02-01 13:08:10 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2672473002/ by johnme@chromium.org.

The reason for reverting is: Broke
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...

All/ScrollingCoordinatorTest.iframeScrolling/1 fails consistently with:

../../third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp:687:
Failure
Value of: innerCompositor->layerForHorizontalScrollbar()
  Actual: false
Expected: true.

Powered by Google App Engine
This is Rietveld 408576698