third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp - Issue 2657553003: Make maybeConvertStandardUnderlyingValue take a ComputedStyle instead of StyleResolverState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

Issue 2657553003: Make maybeConvertStandardUnderlyingValue take a ComputedStyle instead of StyleResolverState (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSPathInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

index 8401ab53876ef418944c0aac0703dca73e2e738c..5ba322953fba1705331338db8395f6b0ae564279 100644

--- a/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp

@@ -90,12 +90,11 @@ InterpolationValue CSSPaintInterpolationType::maybeConvertValue(

InterpolationValue

CSSPaintInterpolationType::maybeConvertStandardPropertyUnderlyingValue(

- const StyleResolverState& state) const {

+ const ComputedStyle& style) const {

// TODO(alancutter): Support capturing and animating with the visited paint

// color.

StyleColor underlyingColor;

- if (!PaintPropertyFunctions::getColor(cssProperty(), *state.style(),

- underlyingColor))

+ if (!PaintPropertyFunctions::getColor(cssProperty(), style, underlyingColor))

return nullptr;

return InterpolationValue(

CSSColorInterpolationType::createInterpolableColor(underlyingColor));