Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2676993002: Move PropertyRegistry::Registration into PropertyRegistration (Closed)

Created:
3 years, 10 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PropertyRegistry::Registration into PropertyRegistration Before this change PropertyRegistration represented the C++ implementation of the PropertyRegistration IDL interface and nothing else. This patch moves the Registration class out of PropertyRegistry and merges it with PropertyRegistration. This change is to enable forward declarations to what was PropertyRegistry::Registration by making it a top level class. C++ doesn't let you forward declare inner classes. This change is required for removing a dependency on Document in: https://codereview.chromium.org/2654783004 BUG=681424 Review-Url: https://codereview.chromium.org/2676993002 Cr-Commit-Position: refs/heads/master@{#448566} Committed: https://chromium.googlesource.com/chromium/src/+/059255004a9e29dab9936f0527da655a148ce459

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 9 (5 generated)
alancutter (OOO until 2018)
3 years, 10 months ago (2017-02-07 00:57:36 UTC) #2
sashab
Great cl description! :) LGTM
3 years, 10 months ago (2017-02-07 01:38:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676993002/20001
3 years, 10 months ago (2017-02-07 05:05:46 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 06:52:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/059255004a9e29dab9936f0527da...

Powered by Google App Engine
This is Rietveld 408576698