Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2657493002: DevTools: do not consider 'force update on reload' as error. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
dgozman, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not consider 'force update on reload' as error. BUG=681078 Review-Url: https://codereview.chromium.org/2657493002 Cr-Commit-Position: refs/heads/master@{#445890} Committed: https://chromium.googlesource.com/chromium/src/+/67afb991fda86d13f7783a2b0783611fa8d28963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
pfeldman
3 years, 11 months ago (2017-01-24 00:14:17 UTC) #2
pfeldman
3 years, 11 months ago (2017-01-24 00:36:16 UTC) #3
pfeldman
3 years, 11 months ago (2017-01-24 18:50:04 UTC) #5
dgozman
lgtm
3 years, 11 months ago (2017-01-24 20:01:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657493002/1
3 years, 11 months ago (2017-01-24 20:12:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/219137)
3 years, 11 months ago (2017-01-24 20:34:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657493002/1
3 years, 11 months ago (2017-01-24 22:50:04 UTC) #12
horo
lgtm
3 years, 11 months ago (2017-01-25 00:56:23 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 01:10:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67afb991fda86d13f7783a2b0783...

Powered by Google App Engine
This is Rietveld 408576698