Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2657493002: DevTools: do not consider 'force update on reload' as error. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 1cbb53484c4fb6c3748d91ce2849f4e72a673b71..d9fe5dfae72d690e21a505fe04d41b24f2b6f976 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -76,6 +76,9 @@ const char kClaimClientsShutdownErrorMesage[] =
"Failed to claim clients due to Service Worker system shutdown.";
const char kNotRespondingErrorMesage[] = "Service Worker is not responding.";
+const char kForceUpdateInfoMessage[] =
+ "Service Worker was updated because \"Update on load\" was "
+ "checked in DevTools Service Workers toolbar.";
void RunSoon(const base::Closure& callback) {
if (!callback.is_null())
@@ -749,6 +752,11 @@ void ServiceWorkerVersion::ReportError(ServiceWorkerStatusCode status,
}
}
+void ServiceWorkerVersion::ReportForceUpdateToDevTools() {
+ embedded_worker_->AddMessageToConsole(blink::WebConsoleMessage::LevelWarning,
+ kForceUpdateInfoMessage);
+}
+
void ServiceWorkerVersion::SetStartWorkerStatusCode(
ServiceWorkerStatusCode status) {
start_worker_status_ = status;
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698