Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 2657493002: DevTools: do not consider 'force update on reload' as error. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_controllee_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc
index af61d9c522eab4eb1e90444bc36ca3a9d0e8144c..76e9c2d3139b242ea1acf4b0bc601f4edd6c3a0c 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc
+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc
@@ -380,10 +380,7 @@ void ServiceWorkerControlleeRequestHandler::DidUpdateRegistration(
DCHECK_EQ(original_registration->id(), registration_id);
scoped_refptr<ServiceWorkerVersion> new_version =
original_registration->installing_version();
- new_version->ReportError(
- SERVICE_WORKER_OK,
- "ServiceWorker was updated because \"Force update on page load\" was "
- "checked in DevTools Source tab.");
+ new_version->ReportForceUpdateToDevTools();
new_version->set_skip_waiting(true);
new_version->RegisterStatusChangeCallback(base::Bind(
&self::OnUpdatedVersionStatusChanged, weak_factory_.GetWeakPtr(),
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698