Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: content/browser/service_worker/service_worker_version.cc

Issue 2657493002: DevTools: do not consider 'force update on reload' as error. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_version.h" 5 #include "content/browser/service_worker/service_worker_version.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <limits> 9 #include <limits>
10 #include <map> 10 #include <map>
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 // Timeout for waiting for a response to a ping. 69 // Timeout for waiting for a response to a ping.
70 const int kPingTimeoutSeconds = 30; 70 const int kPingTimeoutSeconds = 30;
71 71
72 const char kClaimClientsStateErrorMesage[] = 72 const char kClaimClientsStateErrorMesage[] =
73 "Only the active worker can claim clients."; 73 "Only the active worker can claim clients.";
74 74
75 const char kClaimClientsShutdownErrorMesage[] = 75 const char kClaimClientsShutdownErrorMesage[] =
76 "Failed to claim clients due to Service Worker system shutdown."; 76 "Failed to claim clients due to Service Worker system shutdown.";
77 77
78 const char kNotRespondingErrorMesage[] = "Service Worker is not responding."; 78 const char kNotRespondingErrorMesage[] = "Service Worker is not responding.";
79 const char kForceUpdateInfoMessage[] =
80 "Service Worker was updated because \"Update on load\" was "
81 "checked in DevTools Service Workers toolbar.";
79 82
80 void RunSoon(const base::Closure& callback) { 83 void RunSoon(const base::Closure& callback) {
81 if (!callback.is_null()) 84 if (!callback.is_null())
82 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, callback); 85 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, callback);
83 } 86 }
84 87
85 template <typename CallbackArray, typename Arg> 88 template <typename CallbackArray, typename Arg>
86 void RunCallbacks(ServiceWorkerVersion* version, 89 void RunCallbacks(ServiceWorkerVersion* version,
87 CallbackArray* callbacks_ptr, 90 CallbackArray* callbacks_ptr,
88 const Arg& arg) { 91 const Arg& arg) {
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 void ServiceWorkerVersion::ReportError(ServiceWorkerStatusCode status, 745 void ServiceWorkerVersion::ReportError(ServiceWorkerStatusCode status,
743 const std::string& status_message) { 746 const std::string& status_message) {
744 if (status_message.empty()) { 747 if (status_message.empty()) {
745 OnReportException(base::UTF8ToUTF16(ServiceWorkerStatusToString(status)), 748 OnReportException(base::UTF8ToUTF16(ServiceWorkerStatusToString(status)),
746 -1, -1, GURL()); 749 -1, -1, GURL());
747 } else { 750 } else {
748 OnReportException(base::UTF8ToUTF16(status_message), -1, -1, GURL()); 751 OnReportException(base::UTF8ToUTF16(status_message), -1, -1, GURL());
749 } 752 }
750 } 753 }
751 754
755 void ServiceWorkerVersion::ReportForceUpdateToDevTools() {
756 embedded_worker_->AddMessageToConsole(blink::WebConsoleMessage::LevelWarning,
757 kForceUpdateInfoMessage);
758 }
759
752 void ServiceWorkerVersion::SetStartWorkerStatusCode( 760 void ServiceWorkerVersion::SetStartWorkerStatusCode(
753 ServiceWorkerStatusCode status) { 761 ServiceWorkerStatusCode status) {
754 start_worker_status_ = status; 762 start_worker_status_ = status;
755 } 763 }
756 764
757 void ServiceWorkerVersion::Doom() { 765 void ServiceWorkerVersion::Doom() {
758 DCHECK(!HasControllee()); 766 DCHECK(!HasControllee());
759 SetStatus(REDUNDANT); 767 SetStatus(REDUNDANT);
760 if (running_status() == EmbeddedWorkerStatus::STARTING || 768 if (running_status() == EmbeddedWorkerStatus::STARTING ||
761 running_status() == EmbeddedWorkerStatus::RUNNING) { 769 running_status() == EmbeddedWorkerStatus::RUNNING) {
(...skipping 1191 matching lines...) Expand 10 before | Expand all | Expand 10 after
1953 1961
1954 void ServiceWorkerVersion::CleanUpExternalRequest( 1962 void ServiceWorkerVersion::CleanUpExternalRequest(
1955 const std::string& request_uuid, 1963 const std::string& request_uuid,
1956 ServiceWorkerStatusCode status) { 1964 ServiceWorkerStatusCode status) {
1957 if (status == SERVICE_WORKER_OK) 1965 if (status == SERVICE_WORKER_OK)
1958 return; 1966 return;
1959 external_request_uuid_to_request_id_.erase(request_uuid); 1967 external_request_uuid_to_request_id_.erase(request_uuid);
1960 } 1968 }
1961 1969
1962 } // namespace content 1970 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698