Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2657183002: Use full mapLocalToAncestor machinery in ScrollingCoordinator. (Closed)

Created:
3 years, 10 months ago by szager1
Modified:
3 years, 10 months ago
Reviewers:
flackr, chrishtr, skobes
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use full mapLocalToAncestor machinery in ScrollingCoordinator. ScrollingCoordinator walks down the frame tree calculating non-fast-scrollable regions in global coordinates. Previously, it assumed that mapping coordinates from an iframe to its parent frame just consisted of applying an offset; but an iframe can have an arbitrary transform applied to it. This change makes ScrollingCoordinator map coordinates to the top level using the canonical code path, i.e., mapLocalToAncestor. R=chrishtr@chromium.org,skobes@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2657183002 Cr-Commit-Position: refs/heads/master@{#447114} Committed: https://chromium.googlesource.com/chromium/src/+/a84f6044bfe3bc52dde4c2cdddbbc92be1b56ab1

Patch Set 1 #

Patch Set 2 : test expectations #

Total comments: 5

Patch Set 3 : Comments and nits #

Patch Set 4 : rebase #

Patch Set 5 : Delete unused test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -39 lines) Patch
M third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html View 1 2 2 chunks +24 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 6 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2651793012 Patch 40001

Messages

Total messages: 20 (12 generated)
szager1
3 years, 10 months ago (2017-01-27 09:19:39 UTC) #2
skobes
lgtm w/ nit https://codereview.chromium.org/2657183002/diff/20001/third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html File third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html (right): https://codereview.chromium.org/2657183002/diff/20001/third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html#newcode18 third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:18: <iframe src="resources/non-fast-scrollable-region-transformed-iframe-subframe.html"></iframe> Generally I find srcdoc ...
3 years, 10 months ago (2017-01-27 18:37:25 UTC) #9
chrishtr
Adding flackr as FYI since ScrollingCoordinator will get a certain amount slower due to this ...
3 years, 10 months ago (2017-01-27 20:33:30 UTC) #11
szager1
https://codereview.chromium.org/2657183002/diff/20001/third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html File third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html (right): https://codereview.chromium.org/2657183002/diff/20001/third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html#newcode18 third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:18: <iframe src="resources/non-fast-scrollable-region-transformed-iframe-subframe.html"></iframe> On 2017/01/27 18:37:25, skobes wrote: > Generally ...
3 years, 10 months ago (2017-01-30 18:25:41 UTC) #12
skobes
https://codereview.chromium.org/2657183002/diff/20001/third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html File third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html (right): https://codereview.chromium.org/2657183002/diff/20001/third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html#newcode18 third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:18: <iframe src="resources/non-fast-scrollable-region-transformed-iframe-subframe.html"></iframe> On 2017/01/30 18:25:41, szager1 wrote: > I ...
3 years, 10 months ago (2017-01-30 18:59:53 UTC) #13
chrishtr
lgtm
3 years, 10 months ago (2017-01-30 20:38:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657183002/80001
3 years, 10 months ago (2017-01-30 20:54:37 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 23:57:33 UTC) #20
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a84f6044bfe3bc52dde4c2cdddbb...

Powered by Google App Engine
This is Rietveld 408576698