Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2657183002: Use full mapLocalToAncestor machinery in ScrollingCoordinator. (Closed)
Patch Set: test expectations Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2573 matching lines...) Expand 10 before | Expand all | Expand 10 after
2584 LayoutViewItem viewItem = layoutViewItem(); 2584 LayoutViewItem viewItem = layoutViewItem();
2585 if (!viewItem.isNull()) 2585 if (!viewItem.isNull())
2586 viewItem.clearHitTestCache(); 2586 viewItem.clearHitTestCache();
2587 } 2587 }
2588 2588
2589 IntRect FrameView::scrollableAreaBoundingBox() const { 2589 IntRect FrameView::scrollableAreaBoundingBox() const {
2590 LayoutPartItem ownerLayoutItem = frame().ownerLayoutItem(); 2590 LayoutPartItem ownerLayoutItem = frame().ownerLayoutItem();
2591 if (ownerLayoutItem.isNull()) 2591 if (ownerLayoutItem.isNull())
2592 return frameRect(); 2592 return frameRect();
2593 2593
2594 return ownerLayoutItem.absoluteContentQuad().enclosingBoundingBox(); 2594 return ownerLayoutItem.absoluteContentQuad(TraverseDocumentBoundaries)
chrishtr 2017/01/27 20:33:30 It seems you need to update the definition in Scro
szager1 2017/01/30 18:25:41 Done.
2595 .enclosingBoundingBox();
2595 } 2596 }
2596 2597
2597 bool FrameView::isScrollable() { 2598 bool FrameView::isScrollable() {
2598 return getScrollingReasons() == Scrollable; 2599 return getScrollingReasons() == Scrollable;
2599 } 2600 }
2600 2601
2601 bool FrameView::isProgrammaticallyScrollable() { 2602 bool FrameView::isProgrammaticallyScrollable() {
2602 return !m_inUpdateScrollbars; 2603 return !m_inUpdateScrollbars;
2603 } 2604 }
2604 2605
(...skipping 2456 matching lines...) Expand 10 before | Expand all | Expand 10 after
5061 std::unique_ptr<CompositorAnimationTimeline> timeline) { 5062 std::unique_ptr<CompositorAnimationTimeline> timeline) {
5062 m_animationTimeline = std::move(timeline); 5063 m_animationTimeline = std::move(timeline);
5063 } 5064 }
5064 5065
5065 void FrameView::setAnimationHost( 5066 void FrameView::setAnimationHost(
5066 std::unique_ptr<CompositorAnimationHost> host) { 5067 std::unique_ptr<CompositorAnimationHost> host) {
5067 m_animationHost = std::move(host); 5068 m_animationHost = std::move(host);
5068 } 5069 }
5069 5070
5070 } // namespace blink 5071 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698