third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html - Issue 2657183002: Use full mapLocalToAncestor machinery in ScrollingCoordinator.

Side by Side Diff: third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

Issue 2657183002: Use full mapLocalToAncestor machinery in ScrollingCoordinator. (Closed)

Patch Set: test expectations Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 iframe {	3 iframe {

4 position: absolute;	4 position: absolute;

5 left: 200px;	5 left: 200px;

6 top: 200px;	6 top: 200px;

7 height: 120px;	7 height: 200px;

8 width: 120px;	8 width: 200px;

9 padding: 10px;	9 padding: 10px;

10 border: none;	10 border: none;

11 transform: scale(2);	11 transform: scale(2);

12 }	12 }

	13 .spacer {

	14 height: 2000px;

	15 }

13 </style>	16 </style>

14	17

15 <iframe src="data:text/html;charset=utf-8,<html><body style='width:1000px; heigh t:1000px;'><p style='font-size: 6px'>Should be covered by a green overlay.</p></ body></html>"></iframe>	18 <iframe src="resources/non-fast-scrollable-region-transformed-iframe-subframe.ht ml"></iframe>
	skobes 2017/01/27 18:37:25 Generally I find srcdoc to be nicer than adding se Generally I find srcdoc to be nicer than adding separate files under resources. <iframe srcdoc=" <!DOCTYPE html> ... "></iframe> szager1 2017/01/30 18:25:41 I converted it to srcdoc, but I don't really feel Show quoted text On 2017/01/27 18:37:25, skobes wrote: > Generally I find srcdoc to be nicer than adding separate files under resources. > > <iframe srcdoc=" > <!DOCTYPE html> > ... > "></iframe> I converted it to srcdoc, but I don't really feel like it adds clarity. I had to use " to define the inner srcdoc, and I actually find it harder to read now. WDYT? skobes 2017/01/30 18:59:53 Yes the " is a bit gross but I find it easier Show quoted text On 2017/01/30 18:25:41, szager1 wrote: > I converted it to srcdoc, but I don't really feel like it adds clarity. I had > to use " to define the inner srcdoc, and I actually find it harder to read > now. > > WDYT? Yes the " is a bit gross but I find it easier to see everything in one file.
16 <div id="console"></div>	19 <div id="console"></div>

	20 <div class="spacer"></div>

17	21

18 <script src="../resources/js-test.js"></script>	22 <script src="../resources/js-test.js"></script>

19 <script src="../resources/run-after-layout-and-paint.js"></script>	23 <script src="../resources/run-after-layout-and-paint.js"></script>

20 <script src="resources/non-fast-scrollable-region-testing.js"></script>	24 <script src="resources/non-fast-scrollable-region-testing.js"></script>

21 <script>	25 <script>

22 window.jsTestIsAsync = true;	26 window.jsTestIsAsync = true;

23 description('This test ensures non-fast scrollable areas are calculated ' +	27 description('This test ensures non-fast scrollable areas are calculated ' +

24 'correctly when a CSS scale transformation is applied.');	28 'correctly when a CSS scale transformation is applied.');

25	29

26 onload = function() {	30 onload = function() {

27 runAfterLayoutAndPaint(function(){	31 runAfterLayoutAndPaint(function(){

28 nonFastScrollableRects = window.internals.nonFastScrollableRects(document) ;	32 nonFastScrollableRects = window.internals.nonFastScrollableRects(document) ;

29 shouldBe('nonFastScrollableRects.length', '1');	33 shouldBe('nonFastScrollableRects.length', '1');

30 shouldBeEqualToString('rectToString(nonFastScrollableRects[0])', '[150, 15 0, 240, 240]');	34 shouldBeEqualToString('rectToString(nonFastScrollableRects[0])', '[146, 14 6, 240, 240]');

31	35

32 drawNonFastScrollableRegionOverlays();	36 drawNonFastScrollableRegionOverlays();

33	37

34 finishJSTest();	38 finishJSTest();

35 });	39 });

36 };	40 };

37 </script>	41 </script>

OLD	NEW