Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2656343002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Created:
3 years, 10 months ago by riju_
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, kinuko+watch, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, tzik, nhiroki, tommyw+watchlist_chromium.org, eric.carlson_apple.com, blink-reviews, Srirama, kinuko+fileapi, mcasas+watch+mediastream_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] in core/{events/fileapi} modules/{mediacapture,mediasource,mediastream,quota,speech} BUG=670618 Review-Url: https://codereview.chromium.org/2656343002 Cr-Commit-Position: refs/heads/master@{#447205} Committed: https://chromium.googlesource.com/chromium/src/+/27fc0832721cf08937ae13b403adf2f963fe9ebf

Patch Set 1 #

Patch Set 2 : Document.createEvent; #

Patch Set 3 : Few more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -105 lines) Patch
M third_party/WebKit/Source/core/css/PropertyRegistration.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertyRegistration.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertyRegistration.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/Event.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 3 chunks +18 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/URLFileAPI.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/URLFileAPI.cpp View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/URLFileAPI.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/URLMediaSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/URLMediaSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/URLMediaStream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/URLMediaStream.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 1 2 5 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp View 4 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp View 4 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageQuotaClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechGrammar.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechGrammar.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechGrammar.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/StorageQuotaClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/StorageQuotaClientImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (19 generated)
riju_
PTAL, A few more still remain, were failing some tests, so will tackle them in ...
3 years, 10 months ago (2017-01-30 16:00:25 UTC) #15
haraken
LGTM
3 years, 10 months ago (2017-01-30 16:25:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656343002/60001
3 years, 10 months ago (2017-01-31 07:40:31 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 07:45:19 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/27fc0832721cf08937ae13b403ad...

Powered by Google App Engine
This is Rietveld 408576698