third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl - Issue 2656343002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2656343002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Patch Set: Few more Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

index 81853fe4a77919ee8256ffbf6fdf8b24bae260f4..af35b945a8a954155bc06c95e661a630d3fdac98 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

@@ -84,7 +84,7 @@ enum RTCIceConnectionState {

readonly attribute RTCIceConnectionState iceConnectionState;

// readonly attribute boolean? canTrickleIceCandidates;

// RTCConfiguration getConfiguration();

- [CallWith=ExecutionContext, RaisesException] void setConfiguration(RTCConfiguration configuration);

+ [CallWith=ScriptState, RaisesException] void setConfiguration(RTCConfiguration configuration);

// TODO(guidou): close() should never throw an exception.

[RaisesException] void close();

attribute EventHandler onnegotiationneeded;

@@ -115,7 +115,7 @@ enum RTCIceConnectionState {

// https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api

// TODO(guidou): The label argument should have [TreatNullAs=EmptyString]

// and be non-nullable.

- [CallWith=ExecutionContext, RaisesException] RTCDataChannel createDataChannel(DOMString? label, optional Dictionary options);

+ [CallWith=ScriptState, RaisesException] RTCDataChannel createDataChannel(DOMString? label, optional Dictionary options);

attribute EventHandler ondatachannel;

// Certificate management

@@ -126,7 +126,7 @@ enum RTCIceConnectionState {

[Measure] sequence<MediaStream> getLocalStreams();

[Measure] sequence<MediaStream> getRemoteStreams();

[Measure] MediaStream getStreamById(DOMString streamId);

- [Measure, CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);

+ [Measure, CallWith=ScriptState, RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);

[Measure, RaisesException] void removeStream(MediaStream? stream);

[Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track);

attribute EventHandler onaddstream;