third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h - Issue 2656343002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2656343002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Patch Set: Few more Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/URLMediaStream.idl ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

index 413f2707d5289d0cc343c35002cf2fed5b496de3..987ef0f61064bd79383491161abb3d2721ee0106 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

@@ -108,9 +108,7 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

String signalingState() const;

- void setConfiguration(ExecutionContext*,

- const RTCConfiguration&,

- ExceptionState&);

+ void setConfiguration(ScriptState*, const RTCConfiguration&, ExceptionState&);

// Certificate management

// http://w3c.github.io/webrtc-pc/#sec.cert-mgmt

@@ -136,7 +134,7 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

MediaStream* getStreamById(const String& streamId);

- void addStream(ExecutionContext*,

+ void addStream(ScriptState*,

MediaStream*,

const Dictionary& mediaConstraints,

ExceptionState&);

@@ -148,7 +146,7 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

MediaStreamTrack* selector = nullptr);

ScriptPromise getStats(ScriptState*);

- RTCDataChannel* createDataChannel(ExecutionContext*,

+ RTCDataChannel* createDataChannel(ScriptState*,

String label,

const Dictionary& dataChannelDict,

ExceptionState&);