third_party/WebKit/Source/core/dom/Document.cpp - Issue 2656343002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2656343002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Patch Set: Few more Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index d0f32230eb9d19460f541d37edbe76016e63dfc1..6ef0630d57d2d42711f744f095cd31f58813385e 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -4416,10 +4416,11 @@ void Document::registerEventFactory(

eventFactories().insert(std::move(eventFactory));

}

-Event* Document::createEvent(ExecutionContext* executionContext,

+Event* Document::createEvent(ScriptState* scriptState,

const String& eventType,

ExceptionState& exceptionState) {

Event* event = nullptr;

+ ExecutionContext* executionContext = scriptState->getExecutionContext();

for (const auto& factory : eventFactories()) {

event = factory->create(executionContext, eventType);

if (event) {