Add id properties to PointerEvent

Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so we can use it
to keep the id from lower level events from each OS.

In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from ui::PointerEvent,
which are redundant to this new id.

BUG=685817
Review-Url: https://codereview.chromium.org/2655303004
Cr-Commit-Position: refs/heads/master@{#450807}
Committed: https://chromium.googlesource.com/chromium/src/+/31739e48ae970cbc39e8b8cceb168ca86848150a

[lanwei, 2017-01-27 00:10:20]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 00:12:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-27 00:13:15]

Description was changed from

==========
pointer id










BUG=685817
==========

to

==========
Add id properties to PointerEvent on Windows




BUG=685817
==========

[lanwei, 2017-01-27 00:13:16]

lanwei@chromium.org changed reviewers:
+ mustaq@chromium.org

[lanwei, 2017-01-27 00:13:35]

lanwei@chromium.org changed reviewers:
+ dtapuska@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:54:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:54:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[lanwei, 2017-01-27 04:58:14]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 04:58:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-27 05:01:52]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-01-27 05:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 05:05:40]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[lanwei, 2017-01-27 05:49:47]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 05:50:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 07:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 07:13:58]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-01-27 15:42:47]

Patchset #1 (id:20001) has been deleted

[dtapuska, 2017-01-27 15:50:01]

On 2017/01/27 15:43:19, lanwei wrote:

Pointer Ids are unsigned. Does it really make sense for these to be signed?

https://msdn.microsoft.com/en-us/library/windows/desktop/hh454885(v=vs.85).aspx

[lanwei, 2017-01-27 16:12:22]

On 2017/01/27 15:50:01, dtapuska wrote:
> On 2017/01/27 15:43:19, lanwei wrote:
> 
> Pointer Ids are unsigned. Does it really make sense for these to be signed?
> 
>
https://msdn.microsoft.com/en-us/library/windows/desktop/hh454885(v=vs.85).aspx

You are right, should we change the type for WebPointerProperties::id as well?
https://codesearch.chromium.org/chromium/src/third_party/WebKit/public/platfo...

[mustaq, 2017-01-27 17:00:38]

On 2017/01/27 16:12:22, lanwei wrote:
> On 2017/01/27 15:50:01, dtapuska wrote:
> > On 2017/01/27 15:43:19, lanwei wrote:
> > 
> > Pointer Ids are unsigned. Does it really make sense for these to be signed?
> > 
> >
>
https://msdn.microsoft.com/en-us/library/windows/desktop/hh454885(v=vs.85).aspx
> 
> You are right, should we change the type for WebPointerProperties::id as well?
>
https://codesearch.chromium.org/chromium/src/third_party/WebKit/public/platfo...

Perhaps -ve ids don't make sense but PointerEvent.pointerId is also unsigned. I
am slightly biased towards keeping WebPointerProperties.id signed.

[lanwei, 2017-01-29 21:21:55]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 21:22:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 21:44:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 21:44:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lanwei, 2017-01-29 22:14:45]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 22:14:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 23:03:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 23:03:54]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-01-30 03:47:39]

Patchset #2 (id:60001) has been deleted

[mustaq, 2017-01-31 00:24:13]

https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h#newco...
ui/events/event.h:465: uint32_t id = 0;
Where do we set the id from lower level events? Do you think we need to fix
events_win.cc::GetMousePointerDetailsFromNative()? We seem to have a TODO there.

[dtapuska, 2017-01-31 00:25:35]

On 2017/01/31 00:24:13, mustaq wrote:
> https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h
> File ui/events/event.h (right):
> 
>
https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h#newco...
> ui/events/event.h:465: uint32_t id = 0;
> Where do we set the id from lower level events? Do you think we need to fix
> events_win.cc::GetMousePointerDetailsFromNative()? We seem to have a TODO
there.

that is coming in the WM_POINTER changes I believe.

[dtapuska, 2017-01-31 00:26:58]

lgtm

[lanwei, 2017-01-31 02:31:55]

On 2017/01/31 00:25:35, dtapuska wrote:
> On 2017/01/31 00:24:13, mustaq wrote:
> > https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h
> > File ui/events/event.h (right):
> > 
> >
>
https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h#newco...
> > ui/events/event.h:465: uint32_t id = 0;
> > Where do we set the id from lower level events? Do you think we need to fix
> > events_win.cc::GetMousePointerDetailsFromNative()? We seem to have a TODO
> there.
> 
> that is coming in the WM_POINTER changes I believe.

Yes, we get the pointer id from WM_Pointer message, UINT32 pointer_id =
GET_POINTERID_WPARAM(w_param);
This patch https://codereview.chromium.org/2648683003/ will set all the
properties for stylus from WM_Pointer message and I will remove the todo later
in it.
Thanks for catching this.

[mustaq, 2017-01-31 15:46:34]

lgtm

[lanwei, 2017-01-31 16:42:40]

lanwei@chromium.org changed reviewers:
+ tdresser@chromium.org

[lanwei, 2017-01-31 16:42:53]

lanwei@chromium.org changed reviewers:
- tdresser@chromium.org

[lanwei, 2017-01-31 16:43:34]

lanwei@chromium.org changed reviewers:
+ sadrul@chromium.org

[lanwei, 2017-01-31 16:43:34]

sadrul@chromium.org: Please review changes in 
ui/, thank you

[sadrul, 2017-01-31 17:05:13]

https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h#newco...
ui/events/event.h:466: 
ui::TouchEvent has a touch_id(), and a unique_event_id(). It also has a
PointerDetails, which now also has a id(). How are they related? Can we remove
one of the ids from TouchEvent?

ditto for ui::PointerEvent.

[lanwei, 2017-02-01 02:58:12]

https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h#newco...
ui/events/event.h:466: 
On 2017/01/31 17:05:13, sadrul wrote:
> ui::TouchEvent has a touch_id(), and a unique_event_id(). It also has a
> PointerDetails, which now also has a id(). How are they related? Can we remove
> one of the ids from TouchEvent?
> 
> ditto for ui::PointerEvent.

This id in PointerDetails makes more senses for stylus type, because we will get
an ID from lower level events from the OS. For touch event, this id will be just
0, and eventually in Blink, the pointer id will be set by the touch_id() from
ui::TouchEvent. I guess we can use get rid of touch_id(), if we will use this
id. Dave, Mustaq, what do you think?

[sadrul, 2017-02-01 20:59:39]

https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h#newco...
ui/events/event.h:466: 
On 2017/02/01 02:58:12, lanwei wrote:
> On 2017/01/31 17:05:13, sadrul wrote:
> > ui::TouchEvent has a touch_id(), and a unique_event_id(). It also has a
> > PointerDetails, which now also has a id(). How are they related? Can we
remove
> > one of the ids from TouchEvent?
> > 
> > ditto for ui::PointerEvent.
> 
> This id in PointerDetails makes more senses for stylus type, because we will
get
> an ID from lower level events from the OS. For touch event, this id will be
just
> 0, and eventually in Blink, the pointer id will be set by the touch_id() from
> ui::TouchEvent. I guess we can use get rid of touch_id(), if we will use this
> id. Dave, Mustaq, what do you think?

Replacing TouchEvent::touch_id() (and I guess PointerEvent::pointer_id() too)
with this new *Event::PointerDetails::id() sounds reasonable to me.

[lanwei, 2017-02-02 17:25:10]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 17:25:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-02 17:44:44]

On 2017/02/01 20:59:39, sadrul wrote:
> https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h
> File ui/events/event.h (right):
> 
>
https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h#newco...
> ui/events/event.h:466: 
> On 2017/02/01 02:58:12, lanwei wrote:
> > On 2017/01/31 17:05:13, sadrul wrote:
> > > ui::TouchEvent has a touch_id(), and a unique_event_id(). It also has a
> > > PointerDetails, which now also has a id(). How are they related? Can we
> remove
> > > one of the ids from TouchEvent?
> > > 
> > > ditto for ui::PointerEvent.
> > 
> > This id in PointerDetails makes more senses for stylus type, because we will
> get
> > an ID from lower level events from the OS. For touch event, this id will be
> just
> > 0, and eventually in Blink, the pointer id will be set by the touch_id()
from
> > ui::TouchEvent. I guess we can use get rid of touch_id(), if we will use
this
> > id. Dave, Mustaq, what do you think?
> 
> Replacing TouchEvent::touch_id() (and I guess PointerEvent::pointer_id() too)
> with this new *Event::PointerDetails::id() sounds reasonable to me.

Sadrul, I added a TODO to remove the touch_id and pointer_id. The files needed
to be changed will be a lot, I will work on it after we land this one, and may
need to split into two CLs. What do you think?

[sadrul, 2017-02-02 17:46:34]

On 2017/02/02 17:44:44, lanwei wrote:
> On 2017/02/01 20:59:39, sadrul wrote:
> > https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h
> > File ui/events/event.h (right):
> > 
> >
>
https://codereview.chromium.org/2655303004/diff/80001/ui/events/event.h#newco...
> > ui/events/event.h:466: 
> > On 2017/02/01 02:58:12, lanwei wrote:
> > > On 2017/01/31 17:05:13, sadrul wrote:
> > > > ui::TouchEvent has a touch_id(), and a unique_event_id(). It also has a
> > > > PointerDetails, which now also has a id(). How are they related? Can we
> > remove
> > > > one of the ids from TouchEvent?
> > > > 
> > > > ditto for ui::PointerEvent.
> > > 
> > > This id in PointerDetails makes more senses for stylus type, because we
will
> > get
> > > an ID from lower level events from the OS. For touch event, this id will
be
> > just
> > > 0, and eventually in Blink, the pointer id will be set by the touch_id()
> from
> > > ui::TouchEvent. I guess we can use get rid of touch_id(), if we will use
> this
> > > id. Dave, Mustaq, what do you think?
> > 
> > Replacing TouchEvent::touch_id() (and I guess PointerEvent::pointer_id()
too)
> > with this new *Event::PointerDetails::id() sounds reasonable to me.
> 
> Sadrul, I added a TODO to remove the touch_id and pointer_id. The files needed
> to be changed will be a lot, I will work on it after we land this one, and may
> need to split into two CLs. What do you think?

I would rather we do this now. (leaving a confusing state for weeks would not be
a good idea)

[commit-bot: I haz the power, 2017-02-02 18:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 18:45:57]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-02-02 20:33:58]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 20:34:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 20:54:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 20:54:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lanwei, 2017-02-02 22:53:01]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 22:54:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:33:48]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lanwei, 2017-02-03 04:46:45]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-02-03 04:47:11]

Patchset #4 (id:120001) has been deleted

[commit-bot: I haz the power, 2017-02-03 04:47:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-03 04:47:31]

Patchset #4 (id:120001) has been deleted

[commit-bot: I haz the power, 2017-02-03 05:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 05:02:40]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[lanwei, 2017-02-03 05:13:53]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 05:14:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-03 05:15:04]

Patchset #5 (id:160001) has been deleted

[commit-bot: I haz the power, 2017-02-03 05:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 05:43:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lanwei, 2017-02-03 06:14:07]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 06:16:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 07:17:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 07:17:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lanwei, 2017-02-04 03:28:38]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 03:28:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 05:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 05:29:46]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
no build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[lanwei, 2017-02-04 05:40:10]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 05:40:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 07:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 07:41:05]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
no build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[lanwei, 2017-02-04 13:02:49]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 13:02:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 15:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 15:03:26]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
no build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no
build URL)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[lanwei, 2017-02-05 16:52:13]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-05 16:52:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-05 18:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-05 18:38:50]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-02-05 18:50:02]

Patchset #7 (id:220001) has been deleted

[lanwei, 2017-02-05 18:50:24]

Patchset #5 (id:180001) has been deleted

[lanwei, 2017-02-05 18:50:46]

Patchset #4 (id:140001) has been deleted

[lanwei, 2017-02-05 18:55:17]

Patchset #4 (id:200001) has been deleted

[lanwei, 2017-02-05 19:31:33]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-05 19:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-05 20:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-05 20:19:28]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-02-05 20:21:02]

Patchset #4 (id:240001) has been deleted

[lanwei, 2017-02-05 20:47:10]

Patchset #4 (id:260001) has been deleted

[lanwei, 2017-02-05 20:47:55]

Sadrul, could you please take another look, I removed the touch_id and
pointer_id, thank you?

[sadrul, 2017-02-07 05:40:42]

Can you update the CL description?

Is there a reason to prefer uint32_t instead of int (which is what touch-id used
to be)? If we are switching to uint32_t, then we probably need to update some
more code.

https://codereview.chromium.org/2655303004/diff/280001/ash/touch/touch_uma.cc
File ash/touch/touch_uma.cc (right):

https://codereview.chromium.org/2655303004/diff/280001/ash/touch/touch_uma.cc...
ash/touch/touch_uma.cc:122: 
It may be better to extract the id here, and just use that in all the places
below.

https://codereview.chromium.org/2655303004/diff/280001/mash/simple_wm/move_lo...
File mash/simple_wm/move_loop.cc (right):

https://codereview.chromium.org/2655303004/diff/280001/mash/simple_wm/move_lo...
mash/simple_wm/move_loop.cc:104: // GetWindowUserSetBounds(target)),
Since you are here, delete this line?

https://codereview.chromium.org/2655303004/diff/280001/services/ui/ws/drag_co...
File services/ui/ws/drag_controller.cc (right):

https://codereview.chromium.org/2655303004/diff/280001/services/ui/ws/drag_co...
services/ui/ws/drag_controller.cc:89: if (event.pointer_details().id !=
static_cast<uint32_t>(drag_pointer_id_))
Make |drag_pointer_id_| a uint32_t too?

https://codereview.chromium.org/2655303004/diff/280001/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2655303004/diff/280001/ui/events/event.cc#new...
ui/events/event.cc:1032: details_.id = static_cast<uint32_t>(kMousePointerId);
Should not be necessary?

https://codereview.chromium.org/2655303004/diff/280001/ui/events/event.cc#new...
ui/events/event.cc:1088: std::numeric_limits<int32_t>::max();
uint32_t

[lanwei, 2017-02-07 20:24:38]

Description was changed from

==========
Add id properties to PointerEvent on Windows




BUG=685817
==========

to

==========
Add id properties to PointerEvent on Windows

We add id to PointerDetails which will be used as PointerEvent's pointerId.
In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent, which are redundant to this new id.

BUG=685817
==========

[lanwei, 2017-02-07 20:24:55]

Description was changed from

==========
Add id properties to PointerEvent on Windows

We add id to PointerDetails which will be used as PointerEvent's pointerId.
In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent, which are redundant to this new id.

BUG=685817
==========

to

==========
Add id properties to PointerEvent on Windows

We add id to PointerDetails which will be used as PointerEvent's pointerId.
In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817
==========

[lanwei, 2017-02-07 22:59:05]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 22:59:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 02:09:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 02:09:05]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lanwei, 2017-02-08 20:22:03]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 20:23:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 20:26:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 20:26:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lanwei, 2017-02-08 20:34:54]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-02-08 20:35:01]

Patchset #8 (id:360001) has been deleted

[lanwei, 2017-02-08 20:35:38]

Patchset #5 (id:300001) has been deleted

[commit-bot: I haz the power, 2017-02-08 20:35:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:04:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:04:08]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[lanwei, 2017-02-08 22:03:45]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-02-08 22:04:11]

Patchset #7 (id:380001) has been deleted

[commit-bot: I haz the power, 2017-02-08 22:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:32:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:32:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lanwei, 2017-02-09 23:26:48]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 23:27:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 23:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 23:30:58]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lanwei, 2017-02-09 23:55:31]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-02-09 23:55:48]

Patchset #9 (id:440001) has been deleted

[commit-bot: I haz the power, 2017-02-09 23:56:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-10 00:17:30]

Patchset #5 (id:320001) has been deleted

[lanwei, 2017-02-10 00:18:03]

Patchset #5 (id:340001) has been deleted

[commit-bot: I haz the power, 2017-02-10 01:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 01:54:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lanwei, 2017-02-10 07:03:16]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 07:03:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 07:43:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 07:43:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[lanwei, 2017-02-10 13:58:18]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 13:58:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-10 13:58:43]

Patchset #9 (id:500001) has been deleted

[lanwei, 2017-02-10 13:59:10]

Patchset #9 (id:520001) has been deleted

[lanwei, 2017-02-10 13:59:46]

Patchset #7 (id:460001) has been deleted

[commit-bot: I haz the power, 2017-02-10 15:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 15:36:49]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lanwei, 2017-02-10 16:03:55]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-02-10 16:04:19]

The CQ bit was unchecked by lanwei@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:04:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-10 16:26:07]

Patchset #9 (id:560001) has been deleted

[lanwei, 2017-02-10 16:26:36]

Patchset #5 (id:400001) has been deleted

[lanwei, 2017-02-10 16:27:41]

Patchset #5 (id:420001) has been deleted

[lanwei, 2017-02-10 16:31:53]

Patchset #5 (id:480001) has been deleted

[lanwei, 2017-02-10 17:42:58]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 17:43:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-10 17:49:06]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 17:49:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:43:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 19:43:18]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-02-10 20:54:38]

https://codereview.chromium.org/2655303004/diff/280001/mash/simple_wm/move_lo...
File mash/simple_wm/move_loop.cc (right):

https://codereview.chromium.org/2655303004/diff/280001/mash/simple_wm/move_lo...
mash/simple_wm/move_loop.cc:104: // GetWindowUserSetBounds(target)),
On 2017/02/07 05:40:41, sadrul wrote:
> Since you are here, delete this line?

Done.

https://codereview.chromium.org/2655303004/diff/280001/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2655303004/diff/280001/ui/events/event.cc#new...
ui/events/event.cc:1032: details_.id = static_cast<uint32_t>(kMousePointerId);
On 2017/02/07 05:40:42, sadrul wrote:
> Should not be necessary?

Done.

https://codereview.chromium.org/2655303004/diff/280001/ui/events/event.cc#new...
ui/events/event.cc:1088: std::numeric_limits<int32_t>::max();
On 2017/02/07 05:40:42, sadrul wrote:
> uint32_t

Done.

[lanwei, 2017-02-10 21:26:25]

Patchset #5 (id:540001) has been deleted

[lanwei, 2017-02-10 21:26:54]

Patchset #5 (id:580001) has been deleted

[lanwei, 2017-02-10 21:57:35]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 21:58:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 23:20:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 23:20:20]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-02-13 16:47:43]

Some more nits. lgtm with those addressed. Looks like GetTouchId() can be
removed now, so let's do that in a follow up CL.

https://codereview.chromium.org/2655303004/diff/610001/ash/touch/touch_uma.cc
File ash/touch/touch_uma.cc (right):

https://codereview.chromium.org/2655303004/diff/610001/ash/touch/touch_uma.cc...
ash/touch/touch_uma.cc:125: int touch_pointer_id = event.pointer_details().id;
Make this const

https://codereview.chromium.org/2655303004/diff/610001/components/exo/touch.cc
File components/exo/touch.cc (right):

https://codereview.chromium.org/2655303004/diff/610001/components/exo/touch.c...
components/exo/touch.cc:71: int touch_pointer_id = event->pointer_details().id;
Make this const

https://codereview.chromium.org/2655303004/diff/610001/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2655303004/diff/610001/ui/events/event.cc#new...
ui/events/event.cc:553: if (pointer_id == -1) {
Instead of -1, use some const, e.g. PointerDetails::kUnknownPointerId (or
something like that).

https://codereview.chromium.org/2655303004/diff/610001/ui/events/event.cc#new...
ui/events/event.cc:557: }
Use a delegated constructor, instead of repeating this block everywhere.

https://codereview.chromium.org/2655303004/diff/610001/ui/events/events_defau...
File ui/events/events_default.cc (right):

https://codereview.chromium.org/2655303004/diff/610001/ui/events/events_defau...
ui/events/events_default.cc:100: return event->pointer_details().id;
Is GetTouchId() called from anywhere anymore? If not, can you remove that?
(maybe in a separate CL)

[sadrul, 2017-02-13 16:48:21]

Also, this sets the id on all platforms. So please update the CL description
accordingly.

[lanwei, 2017-02-13 20:03:06]

Description was changed from

==========
Add id properties to PointerEvent on Windows

We add id to PointerDetails which will be used as PointerEvent's pointerId.
In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817
==========

to

==========
Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so
we can use it to keep the id from lower level events from each OS.
In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817
==========

[lanwei, 2017-02-13 20:37:01]

Description was changed from

==========
Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so
we can use it to keep the id from lower level events from each OS.
In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817
==========

to

==========
Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so
we can use it
to keep the id from lower level events from each OS.
In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817
==========

[lanwei, 2017-02-13 20:37:19]

Description was changed from

==========
Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so
we can use it
to keep the id from lower level events from each OS.
In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817
==========

to

==========
Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so
we can use it
to keep the id from lower level events from each OS.

In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817
==========

[lanwei, 2017-02-13 21:41:35]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 21:42:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-13 21:43:06]

lanwei@chromium.org changed reviewers:
+ brettw@chromium.org

[lanwei, 2017-02-13 21:44:33]

lanwei@chromium.org changed reviewers:
+ dcheng@chromium.org

[lanwei, 2017-02-13 21:45:11]

lanwei@chromium.org changed reviewers:
- brettw@chromium.org

[lanwei, 2017-02-13 21:46:16]

lanwei@chromium.org changed reviewers:
+ brettw@chromium.org

[lanwei, 2017-02-13 21:50:29]

brettw@ could you please take a look at files in
ash/ , mash/, services/,

dcheng@ could you please take a look at ui/events/mojo/event_struct_traits.cc

thank you?

https://codereview.chromium.org/2655303004/diff/610001/ash/touch/touch_uma.cc
File ash/touch/touch_uma.cc (right):

https://codereview.chromium.org/2655303004/diff/610001/ash/touch/touch_uma.cc...
ash/touch/touch_uma.cc:125: int touch_pointer_id = event.pointer_details().id;
On 2017/02/13 16:47:42, sadrul wrote:
> Make this const

Done.

https://codereview.chromium.org/2655303004/diff/610001/components/exo/touch.cc
File components/exo/touch.cc (right):

https://codereview.chromium.org/2655303004/diff/610001/components/exo/touch.c...
components/exo/touch.cc:71: int touch_pointer_id = event->pointer_details().id;
On 2017/02/13 16:47:42, sadrul wrote:
> Make this const

Done.

https://codereview.chromium.org/2655303004/diff/610001/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2655303004/diff/610001/ui/events/event.cc#new...
ui/events/event.cc:553: if (pointer_id == -1) {
On 2017/02/13 16:47:42, sadrul wrote:
> Instead of -1, use some const, e.g. PointerDetails::kUnknownPointerId (or
> something like that).

Done.

https://codereview.chromium.org/2655303004/diff/610001/ui/events/event.cc#new...
ui/events/event.cc:557: }
On 2017/02/13 16:47:42, sadrul wrote:
> Use a delegated constructor, instead of repeating this block everywhere.

Done.

https://codereview.chromium.org/2655303004/diff/610001/ui/events/events_defau...
File ui/events/events_default.cc (right):

https://codereview.chromium.org/2655303004/diff/610001/ui/events/events_defau...
ui/events/events_default.cc:100: return event->pointer_details().id;
On 2017/02/13 16:47:43, sadrul wrote:
> Is GetTouchId() called from anywhere anymore? If not, can you remove that?
> (maybe in a separate CL)

Done.

[commit-bot: I haz the power, 2017-02-13 23:15:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:15:02]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-02-13 23:15:56]

ipc lgtm

[brettw, 2017-02-15 18:13:37]

LGTM for mechanical changes in ash, mash, and services.

[lanwei, 2017-02-15 18:22:31]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 18:23:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 19:59:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 19:59:28]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[lanwei, 2017-02-15 20:03:11]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2017-02-15 20:03:12]

The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org,
dtapuska@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2655303004/#ps630001
(title: "pointer id")

[commit-bot: I haz the power, 2017-02-15 20:04:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 21:30:01]

CQ is committing da patch.

Bot data: {"patchset_id": 630001, "attempt_start_ts": 1487188991721290,
"parent_rev": "307befe4b9981bcd19c4f2b2ca189cca588a7d8e", "commit_rev":
"31739e48ae970cbc39e8b8cceb168ca86848150a"}

[commit-bot: I haz the power, 2017-02-15 21:30:44]

Description was changed from

==========
Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so
we can use it
to keep the id from lower level events from each OS.

In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817
==========

to

==========
Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so
we can use it
to keep the id from lower level events from each OS.

In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from
ui::PointerEvent,
which are redundant to this new id.

BUG=685817

Review-Url: https://codereview.chromium.org/2655303004
Cr-Commit-Position: refs/heads/master@{#450807}
Committed:
https://chromium.googlesource.com/chromium/src/+/31739e48ae970cbc39e8b8cceb16...
==========

[commit-bot: I haz the power, 2017-02-15 21:30:47]

Committed patchset #7 (id:630001) as
https://chromium.googlesource.com/chromium/src/+/31739e48ae970cbc39e8b8cceb16...

[mustaq, 2017-02-27 16:02:27]

Re the pinch-zoom on CrOS (crbug.com/695905): TouchEvent(NativeEvent&) seems to
skip the id (plus a few drive-by comments)...

https://codereview.chromium.org/2655303004/diff/630001/ui/events/blink/web_in...
File ui/events/blink/web_input_event_builders_win.cc (right):

https://codereview.chromium.org/2655303004/diff/630001/ui/events/blink/web_in...
ui/events/blink/web_input_event_builders_win.cc:170: result.id =
ui::PointerEvent::kMousePointerId;
Are we sure that stylus events are not going through this? Hardcoded ids could
cause problems with stylus ids, even after we migrate to WM_POINTER events
because legacy systems could still pass stylus events as WM_MOUSE events.

https://codereview.chromium.org/2655303004/diff/630001/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/2655303004/diff/630001/ui/events/event.cc#new...
ui/events/event.cc:832: : LocatedEvent(native_event),
I think the bug with pinch-zoom on CrOS (crbug.com/695905) is caused by this
particular constructor: we are not using the value GetTouchId(native_event) now.
Please update this, ideally GetTouchPointerDetailsFromNative() should pull the
native id.

https://codereview.chromium.org/2655303004/diff/630001/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/2655303004/diff/630001/ui/events/x/events_x.c...
ui/events/x/events_x.cc:165: /* twist */ 0,
GetTouchIdFromXEvent(*native_event));
Nit: odd formatting.