Chromium Code Reviews
Help | Chromium Project | Sign in
(30)

Issue 2648683003: Introduce WM_POINTER to Handle pointer events with pen type

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by lanwei
Modified:
41 minutes ago
Reviewers:
dtapuska, ananta, sky, mustaq
CC:
chromium-reviews, jam, darin-cc_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce WM_POINTER to Handle pointer events with pen type BUG=367113

Patch Set 1 #

Total comments: 3

Patch Set 2 : wmpointer #

Patch Set 3 : wmpointer #

Patch Set 4 : wm pointer #

Patch Set 5 : wm pointer #

Total comments: 6

Patch Set 6 : wm pointer #

Total comments: 1

Patch Set 7 : remove if #

Total comments: 2

Patch Set 8 : remove pointerinfo #

Total comments: 4

Patch Set 9 : change to ptPixelLocationRaw #

Patch Set 10 : wm pointer #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -1 line) Patch
M content/browser/renderer_host/legacy_render_widget_host_win.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 1 2 3 4 5 6 7 1 chunk +13 lines, -0 lines 0 comments Download
M ui/base/win/window_event_target.h View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 2 3 4 5 3 chunks +10 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 3 4 5 6 7 8 9 3 chunks +97 lines, -0 lines 5 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 90 (70 generated)
lanwei
2 months ago (2017-01-20 22:28:02 UTC) #5
dtapuska
anantha@ this isn't ready for review yet but if you have some rough comments about ...
2 months ago (2017-01-23 14:15:38 UTC) #9
lanwei
ananta@ this isn't ready for review yet but if you have some rough comments about ...
2 months ago (2017-01-23 19:26:06 UTC) #11
mustaq
https://codereview.chromium.org/2648683003/diff/1/ui/views/win/hwnd_message_handler.h File ui/views/win/hwnd_message_handler.h (right): https://codereview.chromium.org/2648683003/diff/1/ui/views/win/hwnd_message_handler.h#newcode226 ui/views/win/hwnd_message_handler.h:226: LRESULT HandleMouseMessage(unsigned int message, Do we need to do ...
1 month, 3 weeks ago (2017-01-26 19:19:35 UTC) #13
ananta
On 2017/01/26 19:19:35, mustaq wrote: > https://codereview.chromium.org/2648683003/diff/1/ui/views/win/hwnd_message_handler.h > File ui/views/win/hwnd_message_handler.h (right): > > https://codereview.chromium.org/2648683003/diff/1/ui/views/win/hwnd_message_handler.h#newcode226 > ...
1 month, 3 weeks ago (2017-01-27 19:28:36 UTC) #14
ananta
https://codereview.chromium.org/2648683003/diff/100001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/100001/ui/views/win/hwnd_message_handler.cc#newcode946 ui/views/win/hwnd_message_handler.cc:946: if (is_pointer_in_range_) Does not appear to be set anywhere. ...
2 weeks, 1 day ago (2017-03-09 00:37:33 UTC) #28
lanwei
https://codereview.chromium.org/2648683003/diff/100001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/100001/ui/views/win/hwnd_message_handler.cc#newcode946 ui/views/win/hwnd_message_handler.cc:946: if (is_pointer_in_range_) On 2017/03/09 00:37:33, ananta wrote: > Does ...
2 weeks, 1 day ago (2017-03-09 21:05:06 UTC) #45
ananta
https://codereview.chromium.org/2648683003/diff/180001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/180001/ui/views/win/hwnd_message_handler.cc#newcode1663 ui/views/win/hwnd_message_handler.cc:1663: static GetPointerTypeFn get_pointer_type = reinterpret_cast<GetPointerTypeFn>( Instead of these if's ...
1 week, 2 days ago (2017-03-14 22:58:32 UTC) #48
lanwei
1 week, 1 day ago (2017-03-15 22:10:43 UTC) #56
dtapuska
https://codereview.chromium.org/2648683003/diff/220001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/220001/ui/views/win/hwnd_message_handler.cc#newcode1698 ui/views/win/hwnd_message_handler.cc:1698: using GetPointerInfoFn = BOOL(WINAPI*)(UINT32, POINTER_INFO*); This looks a little ...
1 week ago (2017-03-17 13:49:39 UTC) #57
lanwei
https://codereview.chromium.org/2648683003/diff/220001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/220001/ui/views/win/hwnd_message_handler.cc#newcode1698 ui/views/win/hwnd_message_handler.cc:1698: using GetPointerInfoFn = BOOL(WINAPI*)(UINT32, POINTER_INFO*); On 2017/03/17 13:49:39, dtapuska ...
6 days ago (2017-03-18 21:07:47 UTC) #67
mustaq
https://codereview.chromium.org/2648683003/diff/260001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/260001/ui/views/win/hwnd_message_handler.cc#newcode1697 ui/views/win/hwnd_message_handler.cc:1697: POINT client_point = pointer_pen_info.pointerInfo.ptPixelLocation; I think ptPixelLocationRaw is more ...
4 days, 7 hours ago (2017-03-20 14:31:17 UTC) #68
ananta
LGTM % nit https://codereview.chromium.org/2648683003/diff/260001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/260001/ui/views/win/hwnd_message_handler.cc#newcode1693 ui/views/win/hwnd_message_handler.cc:1693: float pressure = (float)pointer_pen_info.pressure / 1024; ...
2 days, 2 hours ago (2017-03-22 19:03:27 UTC) #73
lanwei
Sadrul, could you please take a look, thank you? https://codereview.chromium.org/2648683003/diff/260001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/260001/ui/views/win/hwnd_message_handler.cc#newcode1693 ui/views/win/hwnd_message_handler.cc:1693: ...
1 day, 23 hours ago (2017-03-22 22:38:40 UTC) #78
mustaq
lgtm
1 day, 2 hours ago (2017-03-23 19:00:22 UTC) #79
dtapuska
On 2017/03/23 19:00:22, mustaq wrote: > lgtm seems I haven't lgtm'd this yet
1 day, 2 hours ago (2017-03-23 19:21:40 UTC) #83
sadrul
--> sky@ for ui/views/win changes I have some nits: https://codereview.chromium.org/2648683003/diff/320001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/320001/ui/views/win/hwnd_message_handler.cc#newcode982 ui/views/win/hwnd_message_handler.cc:982: ...
1 day, 1 hour ago (2017-03-23 19:59:39 UTC) #85
dtapuska
https://codereview.chromium.org/2648683003/diff/320001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/320001/ui/views/win/hwnd_message_handler.cc#newcode982 ui/views/win/hwnd_message_handler.cc:982: base::WeakPtr<HWNDMessageHandler> ref(weak_factory_.GetWeakPtr()); On 2017/03/23 19:59:38, sadrul wrote: > I ...
1 day, 1 hour ago (2017-03-23 20:02:51 UTC) #86
ananta
https://codereview.chromium.org/2648683003/diff/320001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2648683003/diff/320001/ui/views/win/hwnd_message_handler.cc#newcode982 ui/views/win/hwnd_message_handler.cc:982: base::WeakPtr<HWNDMessageHandler> ref(weak_factory_.GetWeakPtr()); On 2017/03/23 19:59:38, sadrul wrote: > I ...
1 day, 1 hour ago (2017-03-23 20:04:38 UTC) #87
dtapuska
41 minutes ago (2017-03-24 21:14:58 UTC) #90
On 2017/03/23 20:04:38, ananta wrote:
>
https://codereview.chromium.org/2648683003/diff/320001/ui/views/win/hwnd_mess...
> File ui/views/win/hwnd_message_handler.cc (right):
> 
>
https://codereview.chromium.org/2648683003/diff/320001/ui/views/win/hwnd_mess...
> ui/views/win/hwnd_message_handler.cc:982: base::WeakPtr<HWNDMessageHandler>
> ref(weak_factory_.GetWeakPtr());
> On 2017/03/23 19:59:38, sadrul wrote:
> > I am not sure what the WeakPtr<> is useful for (I notice that we use in
> > HandleTouchMessage etc. functions too).
> 
> The instance can be destroyed while processing a message. Hence the weakptr.

sky@ ping
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62