Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2654783004: Store PropertyRegistry::Registrations on CSSInterpolationTypes for registered custom properties (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
sashab, Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record PropertyRegistrations on CSSInterpolationTypes for registered custom properties This change removes the dependency on having access to the Document's PropertyRegistry during animation value conversion. This is part of removing the dependency on StyleResolverState when converting the underlying value to an animation value. That is part of refactoring CSS Transitions to use InterpolationTypes instead of AnimatableValues. That is part of adding support for transitions on registered custom properties. This change removes the dependency on Document by storing the PropertyRegistration on the CSSInterpolationType so that it doesn't need to look up the registration on Document's PropertyRegistry every time. BUG=681424 Review-Url: https://codereview.chromium.org/2654783004 Cr-Commit-Position: refs/heads/master@{#448871} Committed: https://chromium.googlesource.com/chromium/src/+/b556a4992cb17a53683d83d290c4b4736d1727cd

Patch Set 1 #

Patch Set 2 : lint #

Patch Set 3 : Rebased #

Messages

Total messages: 16 (11 generated)
alancutter (OOO until 2018)
3 years, 11 months ago (2017-01-25 07:23:12 UTC) #3
Eric Willigers
lgtm
3 years, 10 months ago (2017-01-30 23:35:14 UTC) #4
sashab
Would prefer this moved to PropertyRegistry but the interpolation type is const on that, so ...
3 years, 10 months ago (2017-02-07 02:15:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654783004/40001
3 years, 10 months ago (2017-02-08 02:38:23 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 02:44:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b556a4992cb17a53683d83d290c4...

Powered by Google App Engine
This is Rietveld 408576698