Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp

Issue 2654783004: Store PropertyRegistry::Registrations on CSSInterpolationTypes for registered custom properties (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp b/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp
index bdff583fc9d79a9cb8c3e5160aaa23fedf6a585a..d401711e81cd2f96b7754120938c6917bfe18ec9 100644
--- a/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp
+++ b/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp
@@ -214,50 +214,4 @@ const CSSValue* CSSSyntaxDescriptor::parse(CSSParserTokenRange range,
isAnimationTainted);
}
-InterpolationTypes CSSSyntaxDescriptor::createInterpolationTypes(
- const AtomicString& propertyName) const {
- PropertyHandle property(propertyName);
- InterpolationTypes interpolationTypes;
- for (const CSSSyntaxComponent& component : m_syntaxComponents) {
- if (component.m_repeatable) {
- // TODO(alancutter): Support animation of repeatable types.
- continue;
- }
-
- switch (component.m_type) {
- case CSSSyntaxType::Color:
- interpolationTypes.push_back(
- WTF::makeUnique<CSSColorInterpolationType>(property));
- break;
- case CSSSyntaxType::Length:
- interpolationTypes.push_back(
- WTF::makeUnique<CSSLengthInterpolationType>(property));
- break;
- case CSSSyntaxType::Number:
- case CSSSyntaxType::Percentage:
- case CSSSyntaxType::LengthPercentage:
- case CSSSyntaxType::Image:
- case CSSSyntaxType::Url:
- case CSSSyntaxType::Integer:
- case CSSSyntaxType::Angle:
- case CSSSyntaxType::Time:
- case CSSSyntaxType::Resolution:
- case CSSSyntaxType::TransformFunction:
- // TODO(alancutter): Support smooth interpolation of these types.
- break;
- case CSSSyntaxType::TokenStream:
- case CSSSyntaxType::Ident:
- case CSSSyntaxType::CustomIdent:
- // Uses the CSSValueInterpolationType added below.
- break;
- default:
- NOTREACHED();
- break;
- }
- }
- interpolationTypes.push_back(
- WTF::makeUnique<CSSValueInterpolationType>(property));
- return interpolationTypes;
-}
-
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.h ('k') | third_party/WebKit/Source/core/css/PropertyRegistration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698