Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2652063003: Remove dependency on StyleResolverState in CSSInterpolationType::maybeConvertUnderlyingValue() (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on StyleResolverState in CSSInterpolationType::maybeConvertUnderlyingValue() In order to use CSSInterpolationTypes to drive CSS Transitions we must remove the dependency that CSSInterpolationType::maybeConvertUnderlyingValue() has on StyleResolverState. During CSS Transition creation there is no StyleResolverState, only ComputedStyle objects. This is in preparation for CSS Transitions using InterpolationTypes. BUG=681424 Review-Url: https://codereview.chromium.org/2652063003 Cr-Commit-Position: refs/heads/master@{#448908} Committed: https://chromium.googlesource.com/chromium/src/+/389b00724cc8c2699446844ff5b8718bd052349f

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationEnvironment.h View 1 4 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
alancutter (OOO until 2018)
3 years, 11 months ago (2017-01-25 07:10:47 UTC) #3
Eric Willigers
lgtm
3 years, 10 months ago (2017-01-26 04:49:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652063003/60001
3 years, 10 months ago (2017-02-08 02:52:00 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 04:49:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/389b00724cc8c2699446844ff5b8...

Powered by Google App Engine
This is Rietveld 408576698