Add 4 ARIA 1.1 attributes using new sparse attribute interface.

Add 4 ARIA 1.1 attributes using new sparse attribute interface.

Adds support for 4 sparse ARIA 1.1 attributes:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-roledescription

Chrome support will be added in this follow-up change:
https://codereview.chromium.org/2587343004/

BUG=675994, 644766
Review-Url: https://codereview.chromium.org/2653063002
Cr-Commit-Position: refs/heads/master@{#447244}
Committed: https://chromium.googlesource.com/chromium/src/+/8ca955425af665573f7ad3210643bcb3486c69b5

[dmazzoni, 2017-01-24 20:29:58]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:30:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-01-24 20:43:36]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[dmazzoni, 2017-01-24 20:43:37]

Alice, ready for a look. I have some questions.

I only implemented inspector-protocol support for
aria-modal so far because I have some questions.

* Is anything more needed to make "modal" show up in the Accessibility sidebar?
The whole Accessibility sidebar is broken for me on trunk, not sure if there's a
known issue. See below for errors.

* What should we do about the fact that "modal" won't show up unless the
attribute is present? We probably want it to always show up if role="dialog" or
"alertdialog", right? Would it make sense to have a first pass that sets the
default value for all sparse attributes and then they get changed? Or a final
pass that sets them if they weren't already set?

Keep in mind that I'd eventually like to make most attributes sparse, so it's
worth taking the time to make this as clean and general as possible.

Here are the errors I'm getting when trying to open the Accessibility sidebar on
trunk:

"XMLHttpRequest cannot load
https://chrome-devtools-frontend.appspot.com/serve_file/@1761cd38fa199b8204a4....
No 'Access-Control-Allow-Origin' header is present on the requested resource.
Origin 'chrome-devtools://devtools' is therefore not allowed access. The
response had HTTP status code 404.", source:
chrome-devtools://devtools/bundled/inspector.html?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@1761cd38fa199b8204a4e17a20599b17bd4b3f0a/&can_dock=true&panel=console&dockSide=undocked&experiments=true
(0)

"Empty response arrived for script
'https://chrome-devtools-frontend.appspot.com/serve_file/@1761cd38fa199b8204a4e17a20599b17bd4b3f0a/accessibility/accessibility_module.js'",
source: chrome-devtools://devtools/bundled/inspector.js (22)

"Uncaught (in promise) Error: Could not instantiate:
Accessibility.AccessibilitySidebarView", source:
chrome-devtools://devtools/bundled/inspector.js (109)

[commit-bot: I haz the power, 2017-01-24 20:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:59:57]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[dmazzoni, 2017-01-26 17:45:43]

Description was changed from

==========
Add 5 ARIA 1.1 attributes using new sparse attribute interface.

Adds support for 5 sparse ARIA 1.1 attributes:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-modal
  aria-roledescription

Chrome support will be added in this follow-up change:
https://codereview.chromium.org/2587343004/

BUG=675994, 644766
==========

to

==========
Add 4 ARIA 1.1 attributes using new sparse attribute interface.

Adds support for 5 sparse ARIA 1.1 attributes:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-roledescription

Chrome support will be added in this follow-up change:
https://codereview.chromium.org/2587343004/

BUG=675994, 644766
==========

[dmazzoni, 2017-01-26 18:17:41]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 18:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-01-26 18:18:26]

OK, ready for another look.

I removed aria-modal from this change and finished
the other four, which I think are reasonable as-is.

[commit-bot: I haz the power, 2017-01-26 19:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 19:03:10]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aboxhall, 2017-01-27 01:41:22]

LGTM with nits

https://codereview.chromium.org/2653063002/diff/20001/content/renderer/access...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/2653063002/diff/20001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:109: // TODO
TODO needs completing (still TODO?)

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html
(right):

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html:19:
<h3 data-dump id="err">This text field has an error!</h3>
Why is this being dumped?

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html:22:
<div data-dump id="d1">Details 1</div>
Similarly, why dump these?

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:196:
axSparseAttributeSetterMap.set(
This is really elegant with all of the infrastructure in place \o/

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
(right):

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp:345:
// TODO
TODO

[dmazzoni, 2017-01-31 00:31:54]

https://codereview.chromium.org/2653063002/diff/20001/content/renderer/access...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/2653063002/diff/20001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:109: // TODO
On 2017/01/27 01:41:21, aboxhall wrote:
> TODO needs completing (still TODO?)

Coming in the immediately-following change:

https://codereview.chromium.org/2587343004/

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html
(right):

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html:19:
<h3 data-dump id="err">This text field has an error!</h3>
On 2017/01/27 01:41:22, aboxhall wrote:
> Why is this being dumped?

Done.

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html:22:
<div data-dump id="d1">Details 1</div>
On 2017/01/27 01:41:22, aboxhall wrote:
> Similarly, why dump these?

Done.

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:196:
axSparseAttributeSetterMap.set(
On 2017/01/27 01:41:22, aboxhall wrote:
> This is really elegant with all of the infrastructure in place \o/

:)

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
(right):

https://codereview.chromium.org/2653063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp:345:
// TODO
On 2017/01/27 01:41:22, aboxhall wrote:
> TODO

Nothing to add for this particular change. I changed the comment to say that
we should implement this when we add our first sparse boolean attribute.

[dmazzoni, 2017-01-31 00:42:37]

dmazzoni@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dmazzoni, 2017-01-31 00:42:37]

+pfeldman for inspector-protocol and HTMLAttributeNames.in

[dmazzoni, 2017-01-31 00:42:46]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 00:43:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 02:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 02:53:39]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-01-31 04:25:58]

Description was changed from

==========
Add 4 ARIA 1.1 attributes using new sparse attribute interface.

Adds support for 5 sparse ARIA 1.1 attributes:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-roledescription

Chrome support will be added in this follow-up change:
https://codereview.chromium.org/2587343004/

BUG=675994, 644766
==========

to

==========
Add 4 ARIA 1.1 attributes using new sparse attribute interface.

Adds support for 4 sparse ARIA 1.1 attributes:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-roledescription

Chrome support will be added in this follow-up change:
https://codereview.chromium.org/2587343004/

BUG=675994, 644766
==========

[pfeldman, 2017-01-31 16:27:28]

lgtm

[dmazzoni, 2017-01-31 16:35:00]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-01-31 16:35:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2653063002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-31 16:35:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 16:39:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485880500167440,
"parent_rev": "b58d93befd050fa4f397f7d4be064818378b10a2", "commit_rev":
"8ca955425af665573f7ad3210643bcb3486c69b5"}

[commit-bot: I haz the power, 2017-01-31 16:40:18]

Description was changed from

==========
Add 4 ARIA 1.1 attributes using new sparse attribute interface.

Adds support for 4 sparse ARIA 1.1 attributes:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-roledescription

Chrome support will be added in this follow-up change:
https://codereview.chromium.org/2587343004/

BUG=675994, 644766
==========

to

==========
Add 4 ARIA 1.1 attributes using new sparse attribute interface.

Adds support for 4 sparse ARIA 1.1 attributes:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-roledescription

Chrome support will be added in this follow-up change:
https://codereview.chromium.org/2587343004/

BUG=675994, 644766

Review-Url: https://codereview.chromium.org/2653063002
Cr-Commit-Position: refs/heads/master@{#447244}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ca955425af665573f7ad3210643...
==========

[commit-bot: I haz the power, 2017-01-31 16:40:20]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8ca955425af665573f7ad3210643...