Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2653063002: Add 4 ARIA 1.1 attributes using new sparse attribute interface. (Closed)
Patch Set: Remove aria-modal, finish inspector protocol for other 4 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 if (axSparseAttributeSetterMap.isEmpty()) { 186 if (axSparseAttributeSetterMap.isEmpty()) {
187 axSparseAttributeSetterMap.set( 187 axSparseAttributeSetterMap.set(
188 aria_activedescendantAttr, 188 aria_activedescendantAttr,
189 new ObjectAttributeSetter(AXObjectAttribute::AriaActiveDescendant)); 189 new ObjectAttributeSetter(AXObjectAttribute::AriaActiveDescendant));
190 axSparseAttributeSetterMap.set( 190 axSparseAttributeSetterMap.set(
191 aria_controlsAttr, 191 aria_controlsAttr,
192 new ObjectVectorAttributeSetter(AXObjectVectorAttribute::AriaControls)); 192 new ObjectVectorAttributeSetter(AXObjectVectorAttribute::AriaControls));
193 axSparseAttributeSetterMap.set( 193 axSparseAttributeSetterMap.set(
194 aria_flowtoAttr, 194 aria_flowtoAttr,
195 new ObjectVectorAttributeSetter(AXObjectVectorAttribute::AriaFlowTo)); 195 new ObjectVectorAttributeSetter(AXObjectVectorAttribute::AriaFlowTo));
196 axSparseAttributeSetterMap.set(
aboxhall 2017/01/27 01:41:22 This is really elegant with all of the infrastruct
dmazzoni 2017/01/31 00:31:54 :)
197 aria_detailsAttr,
198 new ObjectVectorAttributeSetter(AXObjectVectorAttribute::AriaDetails));
199 axSparseAttributeSetterMap.set(
200 aria_errormessageAttr,
201 new ObjectAttributeSetter(AXObjectAttribute::AriaErrorMessage));
202 axSparseAttributeSetterMap.set(
203 aria_keyshortcutsAttr,
204 new StringAttributeSetter(AXStringAttribute::AriaKeyShortcuts));
205 axSparseAttributeSetterMap.set(
206 aria_roledescriptionAttr,
207 new StringAttributeSetter(AXStringAttribute::AriaRoleDescription));
196 } 208 }
197 return axSparseAttributeSetterMap; 209 return axSparseAttributeSetterMap;
198 } 210 }
199 211
200 AXNodeObject::AXNodeObject(Node* node, AXObjectCacheImpl& axObjectCache) 212 AXNodeObject::AXNodeObject(Node* node, AXObjectCacheImpl& axObjectCache)
201 : AXObject(axObjectCache), 213 : AXObject(axObjectCache),
202 m_ariaRole(UnknownRole), 214 m_ariaRole(UnknownRole),
203 m_childrenDirty(false), 215 m_childrenDirty(false),
204 m_node(node) { 216 m_node(node) {
205 } 217 }
(...skipping 2866 matching lines...) Expand 10 before | Expand all | Expand 10 after
3072 return String(); 3084 return String();
3073 return toTextControlElement(node)->strippedPlaceholder(); 3085 return toTextControlElement(node)->strippedPlaceholder();
3074 } 3086 }
3075 3087
3076 DEFINE_TRACE(AXNodeObject) { 3088 DEFINE_TRACE(AXNodeObject) {
3077 visitor->trace(m_node); 3089 visitor->trace(m_node);
3078 AXObject::trace(visitor); 3090 AXObject::trace(visitor);
3079 } 3091 }
3080 3092
3081 } // namespace blink 3093 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698